Review Board 1.7.22


Dan Dumont
Last logged in May 10th, 2013
Joined June 30th, 2011


ddumont's review requests

Starred Summary Submitter Posted Last Updated Edit columns
Make jscontent max-age configurable for the server. ddumont February 20th, 2013, 5:25 p.m.
Fix issue with commit for SHINDIG-1902 ddumont February 15th, 2013, 6:02 p.m.
Shared token logic confuses shared oauth identity with gadget uri in cache and persistence layers. ddumont January 24th, 2013, 2:39 p.m.
Add some useful tests to the current gadget domain tester. ddumont January 21st, 2013, 10:13 p.m.
Recent rpc changes are breaking gadget to gadget communication ddumont January 8th, 2013, 7:46 p.m.
Create a shindig api for developers to see if their gadgets are rendering in debug mode ddumont November 5th, 2012, 1:51 p.m.
OAuth 1.0a broken with recent oauthpopup changes moving window open to container from gadget ddumont September 19th, 2012, 11:56 p.m.
OAuth 1.0a fixes with new oauthpopup feature ddumont September 13th, 2012, 9:01 p.m.
Move container mixin functionality to a new feature. ddumont September 6th, 2012, 5:43 p.m.
Refactor oauthpopup feature to use rpc to the container ddumont August 23rd, 2012, 9:13 p.m.
Best effort to get onload handlers to run in gadgets with url content sections that load feature script ddumont August 21st, 2012, 6:06 p.m.
Container should not call showAction API for actions with an invalid type. ddumont August 14th, 2012, 1:43 p.m.
Possible js compiler cache miss scenario ddumont June 29th, 2012, 10:51 p.m.
Allow container implementations to more easily override and extend rpc registered service handlers. ddumont July 25th, 2012, 6:23 p.m.
Best effort support for getting a string dataModel ddumont June 17th, 2012, 2:58 a.m.
More container token refresh flexibility. Error handling, waiting, and retries ddumont June 16th, 2012, 11:36 p.m.
proxied-form-post: Write the response in a way that won't be unintentionally un-escaped by browsers. ddumont April 26th, 2012, 7:58 p.m.
Gadgets using gadgets.window.adjustHeight are no longer adjusting to the correct height ddumont May 8th, 2012, 3:35 p.m.
Allow gadgets to properly manage/scroll the content area they have been afforded by the container. ddumont May 2nd, 2012, 8:11 p.m.
Allow site element creation to be asynchronous in open-views features ddumont May 1st, 2012, 6:57 p.m.
Use refreshInterval in makeRequest sparingly. ddumont April 25th, 2012, 2:36 p.m.
Path To JS Servlet Not Passed As Param For Gadgets Of Type URL ddumont April 12th, 2012, 1:26 p.m.
Separate out the different open* APIs into their own features so they can easily be enabled/disabled ddumont April 10th, 2012, 8:18 p.m.
gadgets.selection.getSelection() does not return current selection on initial loading of gadget ddumont March 13th, 2012, 6:27 p.m.
Pass more info into the createElementFor* functions so they can identify the parent site requesting the navigation. ddumont March 13th, 2012, 7:59 p.m.
Pass more information into some lifecycle event listeners. ddumont February 28th, 2012, 8:15 p.m.
Open-Views feature: views opened by gadgets do not always have their resultCallback called. ddumont February 13th, 2012, 10:13 p.m.
new core-gadget feature "proxied-form-post" gadgets.proxiedMultipartFormPost ddumont February 7th, 2012, 1:48 a.m.
Change GadgetSite and UrlSite to both inherit from a common Site class, and GadgetHolder and UrlHolder to inherit from a common SiteHolder class ddumont January 18th, 2012, 8:20 p.m.
CommonContainer token refresh changes for a better UX when tokens expire. ddumont December 13th, 2011, 7:41 p.m.
Update Open View APIs To Support Opening Of Views At Specific Locations ddumont December 7th, 2011, 3:57 p.m.
Actions, selection, and open-views feature issues in a locked domain environment. ddumont December 2nd, 2011, 7:16 p.m.
Update container config values, comments. Make things easier to configure for locked domains. ddumont November 28th, 2011, 8:17 p.m.
Adding sample gadget to demo dynamic height and width ddumont November 14th, 2011, 9:44 p.m.
Push down the token TTL to container page so it can schedule token refreshes accordingly. ddumont October 21st, 2011, 3:23 p.m.
Security Token Cleanup in preparation for ContainerConfig controlled token expirations ddumont October 16th, 2011, 3:59 a.m.
Use injected config for rpc endpoint in common container service as defaults if not provided. ddumont October 11th, 2011, 6:54 p.m.
Locked domain cleanup and shared-domain-locking feature ddumont September 22nd, 2011, 8:36 p.m.
Implement Specification: Issue 1210: Extend actions feature to allow container to register listeners for when actions are run ddumont August 31st, 2011, 7:58 p.m.
shared-script-frame feature ddumont September 8th, 2011, 1:34 p.m.
Change osapi._registerMethods to 'last one in wins' ddumont July 27th, 2011, 9:43 p.m.
Updates to language/pref handling in the common container code. ddumont July 5th, 2011, 7:09 p.m.
gadget_holder.getIframeElement fails to return the iframe element when pubsub-2 feature is in use ddumont June 30th, 2011, 2:41 p.m.
Found typo in gadget_site.js ddumont July 27th, 2011, 3:50 a.m.
Remove duplicate code accidentally included ddumont August 17th, 2011, 9:10 p.m.
Allow slow-to-init gadgets to safely rely on gadgets.util.registerOnLoadHandler ddumont August 16th, 2011, 4:48 p.m.
Enable closure compiler by default ddumont July 22nd, 2011, 1:59 a.m.
Change the GET_PREFERENCES api to be asynchronous ddumont August 11th, 2011, 11:29 p.m.
vw is undefined in dynamic-width feature ddumont September 6th, 2011, 5:30 p.m.
Declared actions get fired in the first instance of the gadget, ignoring any specified view target in the declaration ddumont August 30th, 2011, 2:01 p.m.
Issue in recent callSameDomain rpc changes when not using same domain ddumont August 24th, 2011, 4:27 p.m.