Review Board 1.7.22


SQOOP-952 Sqoop2: Create job function requires uppercased type name

Review Request #9988 - Created March 16, 2013 and submitted

Jarek Cecho
SQOOP-952
Reviewers
Sqoop
sqoop-sqoop2
I've added "toUpperCase" method call.
Unit and integration tests seems to be working.
client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java
Revision 4fc2a434bca3b96b92e3ac56f348dad783a1edad New Change
[20] 73 lines
[+20] [+] public Object executeFunction(CommandLine line) {
74

    
   
74

   
75
  private void createJob(Long connectionId, String type) throws IOException {
75
  private void createJob(Long connectionId, String type) throws IOException {
76
    printlnResource(Constants.RES_CREATE_CREATING_JOB, connectionId);
76
    printlnResource(Constants.RES_CREATE_CREATING_JOB, connectionId);
77

    
   
77

   
78
    ConsoleReader reader = new ConsoleReader();
78
    ConsoleReader reader = new ConsoleReader();
79
    MJob job = client.newJob(connectionId, MJob.Type.valueOf(type));
79
    MJob job = client.newJob(connectionId, MJob.Type.valueOf(type.toUpperCase()));
80

    
   
80

   
81
    ResourceBundle connectorBundle = client.getResourceBundle(job.getConnectorId());
81
    ResourceBundle connectorBundle = client.getResourceBundle(job.getConnectorId());
82
    ResourceBundle frameworkBundle = client.getFrameworkResourceBundle();
82
    ResourceBundle frameworkBundle = client.getFrameworkResourceBundle();
83

    
   
83

   
84
    Status status = Status.FINE;
84
    Status status = Status.FINE;
[+20] [20] 21 lines
  1. client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java: Loading...