Review Board 1.7.22


SQOOP-919 Sqoop2: Improve Form API for simple java handling

Review Request #9745 - Created March 5, 2013 and submitted

Jarek Cecho
SQOOP-919
Reviewers
Sqoop
sqoop-sqoop2
I've tried to simplify the Java API from perspective of third party user that is integrating with Sqoop.
I've added or tweak unit tests to cover the new functionality. I've also altered the integration test to utilize this API.
common/src/main/java/org/apache/sqoop/model/MConnection.java
Revision bc730bbd1b31f8c48710894e401430412820f51b New Change
[20] 61 lines
[+20] [+] public MConnectionForms getConnectorPart() {
62
  }
62
  }
63

    
   
63

   
64
  public MConnectionForms getFrameworkPart() {
64
  public MConnectionForms getFrameworkPart() {
65
    return frameworkPart;
65
    return frameworkPart;
66
  }
66
  }

    
   
67

   

    
   
68
  public MForm getConnectorForm(String formName) {

    
   
69
    return connectorPart.getForm(formName);

    
   
70
  }

    
   
71

   

    
   
72
  public MForm getFrameworkForm(String formName) {

    
   
73
    return frameworkPart.getForm(formName);

    
   
74
  }
67
}
75
}
common/src/main/java/org/apache/sqoop/model/MConnectionForms.java
Revision 45e4666f83e484047ae7e8edc8b1a77bbdd34cde New Change
 
common/src/main/java/org/apache/sqoop/model/MEnumInput.java
Revision bed2b040c8aa497a4d53a807e35434842dbce344 New Change
 
common/src/main/java/org/apache/sqoop/model/MForm.java
Revision a55fe65b2830f307db6304d31f6398f03482477f New Change
 
common/src/main/java/org/apache/sqoop/model/MFormList.java
New File
 
common/src/main/java/org/apache/sqoop/model/MJobForms.java
Revision 0945a6a2e8e81216e8dac2153e2d433577b83dbc New Change
 
common/src/main/java/org/apache/sqoop/model/ModelError.java
Revision f8d61ef61a6e610452c74b02ffcd033c054183d3 New Change
 
common/src/main/java/org/apache/sqoop/utils/ClassUtils.java.orig
Revision b63fce2aae67261cc5d98f73aae326101f91f27c New Change
 
common/src/test/java/org/apache/sqoop/model/TestMConnection.java
Revision d5f9f38c07e2d54fe86b4d46bcd3f7c974eace45 New Change
 
common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java
Revision 0a3392c9083f1caab3182b88afa3b5c75245a8b7 New Change
 
common/src/test/java/org/apache/sqoop/model/TestMForm.java
Revision 38443a78daf216f3a9fc64e7bf86f4cdd7fffe46 New Change
 
common/src/test/java/org/apache/sqoop/model/TestMFormList.java
New File
 
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java
Revision 538a2777217f322b2b78d2a2715b788da0a2700f New Change
 
  1. common/src/main/java/org/apache/sqoop/model/MConnection.java: Loading...
  2. common/src/main/java/org/apache/sqoop/model/MConnectionForms.java: Loading...
  3. common/src/main/java/org/apache/sqoop/model/MEnumInput.java: Loading...
  4. common/src/main/java/org/apache/sqoop/model/MForm.java: Loading...
  5. common/src/main/java/org/apache/sqoop/model/MFormList.java: Loading...
  6. common/src/main/java/org/apache/sqoop/model/MJobForms.java: Loading...
  7. common/src/main/java/org/apache/sqoop/model/ModelError.java: Loading...
  8. common/src/main/java/org/apache/sqoop/utils/ClassUtils.java.orig: Loading...
  9. common/src/test/java/org/apache/sqoop/model/TestMConnection.java: Loading...
  10. common/src/test/java/org/apache/sqoop/model/TestMEnumInput.java: Loading...
  11. common/src/test/java/org/apache/sqoop/model/TestMForm.java: Loading...
  12. common/src/test/java/org/apache/sqoop/model/TestMFormList.java: Loading...
  13. test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java: Loading...