Review Board 1.7.22


Vasanth kumar RJ got review request #9669!

Sqoop2: Move string constants from FormDisplayer to resource file

Review Request #9669 - Created Feb. 28, 2013 and updated

Vasanth kumar RJ
SQOOP-887
Reviewers
Sqoop
sqoop-sqoop2
Move string constants from FormDisplayer to resource file 
Done
client/src/main/java/org/apache/sqoop/client/core/Constants.java
Revision ae3f994 New Change
[20] 313 lines
[+20] [+] public class Constants {
314
  public static final String RES_TABLE_HEADER_TYPE =
314
  public static final String RES_TABLE_HEADER_TYPE =
315
      "table.header.type";
315
      "table.header.type";
316
  public static final String RES_TABLE_HEADER_CONNECTOR =
316
  public static final String RES_TABLE_HEADER_CONNECTOR =
317
      "table.header.connector";
317
      "table.header.connector";
318

    
   
318

   

    
   
319
  public static final String RES_FORMDISPLAYER_SUPPORTED_JOBTYPE =

    
   
320
      "formdisplayer.supported_job_types";

    
   
321
  public static final String RES_FORMDISPLAYER_CONNECTION =

    
   
322
      "formdisplayer.connection";

    
   
323
  public static final String RES_FORMDISPLAYER_JOB =

    
   
324
      "formdisplayer.job";

    
   
325
  public static final String RES_FORMDISPLAYER_FORM_JOBTYPE =

    
   
326
      "formdisplayer.forms_jobtype";

    
   
327
  public static final String RES_FORMDISPLAYER_FORM =

    
   
328
      "formdisplayer.form";

    
   
329
  public static final String RES_FORMDISPLAYER_NAME =

    
   
330
      "formdisplayer.name";

    
   
331
  public static final String RES_FORMDISPLAYER_LABEL =

    
   
332
      "formdisplayer.label";

    
   
333
  public static final String RES_FORMDISPLAYER_HELP =

    
   
334
      "formdisplayer.help";

    
   
335
  public static final String RES_FORMDISPLAYER_INPUT =

    
   
336
      "formdisplayer.input";

    
   
337
  public static final String RES_FORMDISPLAYER_TYPE =

    
   
338
      "formdisplayer.type";

    
   
339
  public static final String RES_FORMDISPLAYER_MASK =

    
   
340
      "formdisplayer.mask";

    
   
341
  public static final String RES_FORMDISPLAYER_SIZE =

    
   
342
      "formdisplayer.size";

    
   
343
  public static final String RES_FORMDISPLAYER_POSSIBLE_VALUES =

    
   
344
      "formdisplayer.possible_values";

    
   
345
  public static final String RES_FORMDISPLAYER_UNSUPPORTED_DATATYPE =

    
   
346
      "formdisplayer.unsupported_datatype";

    
   
347
  public static final String RES_FORMDISPLAYER_INPUT_SENSITIVE =

    
   
348
      "formdisplayer.input_sensitive";

    
   
349

   
319
  private Constants() {
350
  private Constants() {
320
    // Instantiation is prohibited
351
    // Instantiation is prohibited
321
  }
352
  }
322
}
353
}
client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
Revision 8c133f2 New Change
 
client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java
Revision abd9643 New Change
 
client/src/main/resources/client-resource.properties
Revision c3a22bb New Change
 
  1. client/src/main/java/org/apache/sqoop/client/core/Constants.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java: Loading...
  3. client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java: Loading...
  4. client/src/main/resources/client-resource.properties: Loading...