Review Board 1.7.22


SQOOP-785 Sqoop2: Add splitter implementation for NUMERIC/DECIMAL type

Review Request #9461 - Created Feb. 15, 2013 and submitted

Jarek Cecho
SQOOP-785
Reviewers
Sqoop
sqoop-sqoop2
I've ported BigDecimalSplitter from Sqoop1 into Sqoop2.
I've added unit tests + try the partitioner on real cluster.
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java
Revision 1fcea5f39324a70adf8d6bbec8e51509ef1bac11 New Change
[20] 62 lines
[+20]
63
  GENERIC_JDBC_CONNECTOR_0013("No parameter marker in the specified sql"),
63
  GENERIC_JDBC_CONNECTOR_0013("No parameter marker in the specified sql"),
64

    
   
64

   
65
  /** The table columns cannot be specified when
65
  /** The table columns cannot be specified when
66
   *  the table sql is specified during export. */
66
   *  the table sql is specified during export. */
67
  GENERIC_JDBC_CONNECTOR_0014("The table columns cannot be specified "
67
  GENERIC_JDBC_CONNECTOR_0014("The table columns cannot be specified "
68
      + "when the table sql is specified during export");
68
      + "when the table sql is specified during export"),

    
   
69

   

    
   
70
  /** Unsupported values in partition column */

    
   
71
  GENERIC_JDBC_CONNECTOR_0015("Partition column contains unsupported values"),

    
   
72

   

    
   
73
  ;
69

    
   
74

   
70
  private final String message;
75
  private final String message;
71

    
   
76

   
72
  private GenericJdbcConnectorError(String message) {
77
  private GenericJdbcConnectorError(String message) {
73
    this.message = message;
78
    this.message = message;
[+20] [20] 10 lines
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
Revision d276c577ada94083e74fea03b6235817c991226d New Change
 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
Revision 43eb1c2969d0d15c90b1ec561bef10d787c63521 New Change
 
  1. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java: Loading...
  2. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java: Loading...
  3. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java: Loading...