Review Board 1.7.22


Enhance NettyAvroRpcClient and the use of NettyServer to optionally use compression

Review Request #9427 - Created Feb. 13, 2013 and updated

Ted Malaska
truck
FLUME-1915
Reviewers
Flume
flume-git
Enhance NettyAvroRpcClient and the use of NettyServer to optionally use compression

Description: This JIRA will update AvroSource and NettyAvroRpcClient to optionally use ZlibEncoder and ZlibDecoder to compress communications between themselves.

Patch Comment: Added compression options for both client and server.
Note compress has be turn on both client and server for it to work.
Client can have compression with out compression if compression level is set to 0
Yes
Total:
2
Open:
2
Resolved:
0
Dropped:
0
Status:
From:
Review request changed
Updated (Feb. 27, 2013, 4:34 a.m.)
Addresses all review comments
Ship it!
Posted (March 8, 2013, 12:50 a.m.)
+1, lgtm, I am going to commit this. I have one request for a minor follow-up patch inline.
Can we file a follow-up JIRA to make this only active when compressionType == none or null/empty? A validation / usability nit.