Review Board 1.7.22


SQOOP-864 Sqoop2: Introduce ETL context objects

Review Request #9311 - Created Feb. 5, 2013 and submitted

Jarek Cecho
SQOOP-864
Reviewers
Sqoop
sqoop-sqoop2
This patch seems to be quite enormous, but the logic is fairly simple. I've created family of Context classes - one parent ActorContext and than for each ETL separate child. My reasoning is that each ETL class needs different set of arguments and thus should have it's own Context class. Then I've went and fix all implementations of the ETL classes to conform with the changes.

Each context class is wrapping all parameters in a generic and extensible way. The only parameters that are not part of the Context objects are configuration objects. I wanted to move them into Context classes as well, but that did not work well with the generics, so I kept them separate.
* mvn verify passes for both hadoop 1.x and 2.x
* I've verified the changes on real cluster
Total:
6
Open:
0
Resolved:
6
Dropped:
0
Status:
From:
Description From Last Updated Status
Review request changed
Updated (July 22, 2013, 6:02 p.m.)
  • changed from pending to submitted