Review Board 1.7.22


FLUME-1896. Thrift Rpc Client

Review Request #9283 - Created Feb. 4, 2013 and discarded

Hari Shreedharan
FLUME-1896
Reviewers
Flume
flume-git
Initial implementation of Thrift RPC client. I will add some comments on why the exception handling is done by catching and sending the errors as part of the result.  I had to change some of the pom.xml files which generate thrift java files, because the mvn-thrift plugin is no longer on maven. So, changed the generation code to the one I used. Generating the code requires thrift 0.6.1 - since there is no .thrift file for scribe sources, and thrift generated code is backwards incompatible between 0.9 and 0.6.1.
Added some unit tests. 
pom.xml
Revision 5d59d44 New Change
[20] 137 lines
[+20]
138
        </dependencies>
138
        </dependencies>
139
      </dependencyManagement>
139
      </dependencyManagement>
140
    </profile>
140
    </profile>
141

    
   
141

   
142
    <profile>
142
    <profile>
143
      <id>compileThrift</id>
143
      <id>compileThriftLegacy</id>
144
      <activation>
144
      <activation>
145
        <activeByDefault>false</activeByDefault>
145
        <activeByDefault>false</activeByDefault>
146
      </activation>
146
      </activation>
147
      <properties>
147
      <properties>
148
        <thrift.executable>${env.THRIFT_HOME}/bin/thrift</thrift.executable>
148
        <thrift.executable>${env.THRIFT_HOME}/bin/thrift</thrift.executable>
[+20] [20] 482 lines
[+20]
631
        <artifactId>mockito-all</artifactId>
631
        <artifactId>mockito-all</artifactId>
632
        <version>1.9.0</version>
632
        <version>1.9.0</version>
633
        <scope>test</scope>
633
        <scope>test</scope>
634
      </dependency>
634
      </dependency>
635

    
   
635

   
636
      <dependency>

   
637
        <groupId>org.easytesting</groupId>

   
638
        <artifactId>fest-reflect</artifactId>

   
639
        <version>1.4</version>

   
640
        <scope>test</scope>

   
641
      </dependency>

   
642

    
   

   
643
      <!-- Dependencies: compile -->
636
      <!-- Dependencies: compile -->
644

    
   
637

   
645
      <dependency>
638
      <dependency>
646
        <groupId>commons-cli</groupId>
639
        <groupId>commons-cli</groupId>
647
        <artifactId>commons-cli</artifactId>
640
        <artifactId>commons-cli</artifactId>
[+20] [20] 407 lines
flume-ng-channels/flume-file-channel/pom.xml
Revision 2408447 New Change
 
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java
Revision d921387 New Change
 
flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java
Revision 8a4201c New Change
 
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java
Revision ea57cdb New Change
 
flume-ng-core/pom.xml
Revision ba414bc New Change
 
flume-ng-legacy-sources/flume-thrift-source/pom.xml
Revision b9667cd New Change
 
flume-ng-sdk/pom.xml
Revision ab066d5 New Change
 
flume-ng-sdk/src/main/java/org/apache/flume/api/thrift/ThriftRpcClient.java
New File
 
flume-ng-sdk/src/main/thrift/aslv2
New File
 
flume-ng-sdk/src/main/thrift/flume.thrift
New File
 
flume-ng-sdk/src/test/java/org/apache/flume/api/thrift/TestThriftRpcClient.java
New File
 
flume-ng-sdk/src/test/java/org/apache/flume/api/thrift/ThriftTestingSource.java
New File
 
flume-ng-sinks/flume-hdfs-sink/pom.xml
Revision aaa0e1f New Change
 
flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java
Revision 3f31ef2 New Change
 
flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkSecurityManager.java
Revision 8bf0509 New Change
 
flume-ng-sources/flume-scribe-source/pom.xml
Revision 588207d New Change
 
  1. pom.xml: Loading...
  2. flume-ng-channels/flume-file-channel/pom.xml: Loading...
  3. flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/FileChannel.java: Loading...
  4. flume-ng-channels/flume-file-channel/src/main/java/org/apache/flume/channel/file/Log.java: Loading...
  5. flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java: Loading...
  6. flume-ng-core/pom.xml: Loading...
  7. flume-ng-legacy-sources/flume-thrift-source/pom.xml: Loading...
  8. flume-ng-sdk/pom.xml: Loading...
  9. flume-ng-sdk/src/main/java/org/apache/flume/api/thrift/ThriftRpcClient.java: Loading...
  10. flume-ng-sdk/src/main/thrift/aslv2: Loading...
  11. flume-ng-sdk/src/main/thrift/flume.thrift: Loading...
  12. flume-ng-sdk/src/test/java/org/apache/flume/api/thrift/TestThriftRpcClient.java: Loading...
  13. flume-ng-sdk/src/test/java/org/apache/flume/api/thrift/ThriftTestingSource.java: Loading...
  14. flume-ng-sinks/flume-hdfs-sink/pom.xml: Loading...
  15. flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java: Loading...
  16. flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkSecurityManager.java: Loading...
  17. flume-ng-sources/flume-scribe-source/pom.xml: Loading...