Review Board 1.7.22


Review Request for patch https://issues.apache.org/jira/browse/HIVE-3299

Review Request #9176 - Created Jan. 31, 2013 and updated

Arun A K
https://issues.apache.org/jira/browse/HIVE-3299
Reviewers
hive
hive-git
This seems to be quite useful. Hope this would be reveiewed by the team. 
Testing done successfully. I can find the testcases attached alongside the patch.
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
Revision 425900d New Change
[20] 123 lines
[+20]
124
import org.apache.hadoop.hive.ql.udf.UDFUnhex;
124
import org.apache.hadoop.hive.ql.udf.UDFUnhex;
125
import org.apache.hadoop.hive.ql.udf.UDFUnixTimeStamp;
125
import org.apache.hadoop.hive.ql.udf.UDFUnixTimeStamp;
126
import org.apache.hadoop.hive.ql.udf.UDFUpper;
126
import org.apache.hadoop.hive.ql.udf.UDFUpper;
127
import org.apache.hadoop.hive.ql.udf.UDFWeekOfYear;
127
import org.apache.hadoop.hive.ql.udf.UDFWeekOfYear;
128
import org.apache.hadoop.hive.ql.udf.UDFYear;
128
import org.apache.hadoop.hive.ql.udf.UDFYear;

    
   
129
import org.apache.hadoop.hive.ql.udf.UDFDayName;
129
import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage;
130
import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFAverage;
130
import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFBridge;
131
import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFBridge;
131
import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFCollectSet;
132
import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFCollectSet;
132
import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFContextNGrams;
133
import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFContextNGrams;
133
import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFCorrelation;
134
import org.apache.hadoop.hive.ql.udf.generic.GenericUDAFCorrelation;
[+20] [20] 129 lines
[+20]
263
    registerUDF("ceiling", UDFCeil.class, false);
264
    registerUDF("ceiling", UDFCeil.class, false);
264
    registerUDF("rand", UDFRand.class, false);
265
    registerUDF("rand", UDFRand.class, false);
265
    registerUDF("abs", UDFAbs.class, false);
266
    registerUDF("abs", UDFAbs.class, false);
266
    registerUDF("pmod", UDFPosMod.class, false);
267
    registerUDF("pmod", UDFPosMod.class, false);
267

    
   
268

   
268
    registerUDF("ln", UDFLn.class, false);
269
    registerUDF("ln", UDFLn.class, false); registerUDF("rpad", UDFRpad.class, false);

    
   
270

   
269
    registerUDF("log2", UDFLog2.class, false);
271
    registerUDF("log2", UDFLog2.class, false);
270
    registerUDF("sin", UDFSin.class, false);
272
    registerUDF("sin", UDFSin.class, false);
271
    registerUDF("asin", UDFAsin.class, false);
273
    registerUDF("asin", UDFAsin.class, false);
272
    registerUDF("cos", UDFCos.class, false);
274
    registerUDF("cos", UDFCos.class, false);
273
    registerUDF("acos", UDFAcos.class, false);
275
    registerUDF("acos", UDFAcos.class, false);
[+20] [20] 19 lines
[+20]
293
    registerUDF("lower", UDFLower.class, false);
295
    registerUDF("lower", UDFLower.class, false);
294
    registerUDF("ucase", UDFUpper.class, false);
296
    registerUDF("ucase", UDFUpper.class, false);
295
    registerUDF("lcase", UDFLower.class, false);
297
    registerUDF("lcase", UDFLower.class, false);
296
    registerUDF("trim", UDFTrim.class, false);
298
    registerUDF("trim", UDFTrim.class, false);
297
    registerUDF("ltrim", UDFLTrim.class, false);
299
    registerUDF("ltrim", UDFLTrim.class, false);

    
   
300
    registerUDF("dayname", UDFDayName.class, false);
298
    registerUDF("rtrim", UDFRTrim.class, false);
301
    registerUDF("rtrim", UDFRTrim.class, false);
299
    registerUDF("length", UDFLength.class, false);
302
    registerUDF("length", UDFLength.class, false);
300
    registerUDF("reverse", UDFReverse.class, false);
303
    registerUDF("reverse", UDFReverse.class, false);
301
    registerGenericUDF("field", GenericUDFField.class);
304
    registerGenericUDF("field", GenericUDFField.class);
302
    registerUDF("find_in_set", UDFFindInSet.class, false);
305
    registerUDF("find_in_set", UDFFindInSet.class, false);
[+20] [20] 959 lines
ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayName.java
New File
 
ql/src/test/queries/clientpositive/udf_dayname.q
New File
 
ql/src/test/results/clientpositive/udf_dayname.q.out
New File
 
  1. ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java: Loading...
  2. ql/src/java/org/apache/hadoop/hive/ql/udf/UDFDayName.java: Loading...
  3. ql/src/test/queries/clientpositive/udf_dayname.q: Loading...
  4. ql/src/test/results/clientpositive/udf_dayname.q.out: Loading...