Review Board 1.7.22


SQOOP-818 Missing method setConnManager(Lcom/cloudera/sqoop/manager/ConnManager;)V in ExportJobContContext breaks MS SQL Connector

Review Request #8892 - Created Jan. 8, 2013 and submitted

Jarek Cecho
SQOOP-818
Reviewers
Sqoop
sqoop-trunk
I've added missing method and one missing public inner class.
* SQOOP-820 is needed in order to properly test this
* I've verified on ThirdParty tests that the connector is working using following command:

ant clean test '-Dtestcase=SQLServerManager*' -Dsqoop.test.sqlserver.connectstring.host_url=jdbc:sqlserver://<IP>:1433 -Dsqoop.test.msserver.connector.factory=com.microsoft.sqoop.SqlServer.MSSQLServerManagerFactory

Please note that 2 test are expected to fail as they are testing custom schema support that Connector from Microsoft do not have at the moment, namely:

* SQLServerManagerExportManualTest.testExportCustomSchema()
* SQLServerManagerImportManualTest.testImportDifferentSchema()
src/java/com/cloudera/sqoop/manager/ExportJobContext.java
Revision 552f346 New Change
[20] 28 lines
[+20] [+] public class ExportJobContext
29
  public ExportJobContext(final String table, final String jar,
29
  public ExportJobContext(final String table, final String jar,
30
      final SqoopOptions opts) {
30
      final SqoopOptions opts) {
31
    super(table, jar, opts);
31
    super(table, jar, opts);
32
  }
32
  }
33

    
   
33

   

    
   
34
  public void setConnManager(ConnManager mgr) {

    
   
35
    super.setConnManager(mgr);

    
   
36
  }

    
   
37

   
34
  public ConnManager getConnManager() {
38
  public ConnManager getConnManager() {
35
    return (ConnManager)super.getConnManager();
39
    return (ConnManager)super.getConnManager();
36
  }
40
  }
37
}
41
}
38

    
   
42

   
src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java
Revision dba4a49 New Change
 
  1. src/java/com/cloudera/sqoop/manager/ExportJobContext.java: Loading...
  2. src/java/com/cloudera/sqoop/mapreduce/ExportOutputFormat.java: Loading...