Review Board 1.7.22


Client shell variable substitution for recent commands

Review Request #8842 - Created Jan. 5, 2013 and updated

Vasanth kumar RJ
SQOOP-811
Reviewers
Sqoop
sqoop-sqoop2
execute() method is replaced with executeCommand() method in all Command classes. executed() method overrided in SqoopCommand which resolves the variables and then executes the command.

 
Total:
3
Open:
3
Resolved:
0
Dropped:
0
Status:
From:
Description From Last Updated Status
Nit: Trailing whitespaces Jarek Cecho Jan. 6, 2013, 10:20 a.m. Open
Nit: Trailing whitespaces Jarek Cecho Jan. 6, 2013, 10:20 a.m. Open
Nit: Trailing whitespaces Jarek Cecho Jan. 6, 2013, 10:20 a.m. Open
Ship it!
Posted (Jan. 6, 2013, 10:20 a.m.)
Hi Vasanth,
thank you very much for noticing this! The changes looks good to me, I just have couple of nits. Feel free to upload fixed patch directly to JIRA without another round on review board! I'll be more than happy to commit it.
Nit: Trailing whitespaces
Nit: Trailing whitespaces
Nit: Trailing whitespaces
Jarcec