SQOOP-807 Sqoop2: Verify whether job object can be safely removed prior removing
Review Request #8803 - Created Jan. 2, 2013 and submitted
I've added proposed functionality.
I've added unit test + one unit test for similar function with Connection object.
Posted (Jan. 9, 2013, 8:19 p.m.)
The changes look good to me. One minor comment that I had is that it would be helpful for a reviewer if you added some comments why the these assertions hold. I was able to understand the reason only after reading the loadSubmissions() method in DerbyTestCase. assertTrue(handler.inUseJob(1, getDerbyConnection())); assertFalse(handler.inUseJob(2, getDerbyConnection())); assertFalse(handler.inUseJob(3, getDerbyConnection())); assertFalse(handler.inUseJob(4, getDerbyConnection())); Adding a simple comment like "// See DerbyTestCase regarding why these assertions must hold" will be very helpful. I don't see many comments in test cases now. I guess we can improve it in the future.
Review request changed
Updated (Jan. 25, 2013, 2:23 a.m.)
- changed from pending to submitted