Review Board 1.7.22


Jarek Cecho got review request #8778!

SQOOP-804 Warn if hive special arguments will be used without --hive-import

Review Request #8778 - Created Dec. 29, 2012 and submitted

Jarek Cecho
SQOOP-804
Reviewers
Sqoop
sqoop-trunk
I've added simple check to see if user specified one of hive specific arguments without --hive-import. This patch is introducing one additional checkstyle warning complaining about size of SqoopOptions class. I would suggest to solve that in separate jira as refactoring SqoopOption won't be simple task.
Tested on real cluster on various scenarios and parameter combinations.
src/java/com/cloudera/sqoop/SqoopOptions.java
Revision 8d4f20264cf1f9e5897233dc6c28eb349ecff90d New Change
[20] 85 lines
[+20] [+] public class SqoopOptions
86

    
   
86

   
87
  public static void clearNonceDir() {
87
  public static void clearNonceDir() {
88
    org.apache.sqoop.SqoopOptions.clearNonceDir();
88
    org.apache.sqoop.SqoopOptions.clearNonceDir();
89
  }
89
  }
90

    
   
90

   

    
   
91
  public static String getHiveHomeDefault() {

    
   
92
    return org.apache.sqoop.SqoopOptions.getHiveHomeDefault();

    
   
93
  }

    
   
94

   
91
  /**
95
  /**
92
   * {@inheritDoc}.
96
   * {@inheritDoc}.
93
   * @deprecated
97
   * @deprecated
94
   */
98
   */
95
  public static class InvalidOptionsException
99
  public static class InvalidOptionsException
[+20] [20] 17 lines
src/java/org/apache/sqoop/SqoopOptions.java
Revision 613f7978ea5907854439e9013bec0dbde18e8da3 New Change
 
src/java/org/apache/sqoop/tool/BaseSqoopTool.java
Revision d79564629ba89c539730cf5209c06c7ef694df4e New Change
 
  1. src/java/com/cloudera/sqoop/SqoopOptions.java: Loading...
  2. src/java/org/apache/sqoop/SqoopOptions.java: Loading...
  3. src/java/org/apache/sqoop/tool/BaseSqoopTool.java: Loading...