Review Board 1.7.22


SQOOP-799 Sqoop2: Change SqoopConnector interface to abstract class

Review Request #8733 - Created Dec. 21, 2012 and submitted

Jarek Cecho
SQOOP-799
Reviewers
Sqoop
sqoop-sqoop2
I've changed the implementation as proposed.
Unit tests seems to be passing.
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
Revision ea92d0c New Change
[20] 27 lines
[+20]
28
import org.apache.sqoop.job.etl.Importer;
28
import org.apache.sqoop.job.etl.Importer;
29
import org.apache.sqoop.connector.spi.SqoopConnector;
29
import org.apache.sqoop.connector.spi.SqoopConnector;
30
import org.apache.sqoop.model.MJob;
30
import org.apache.sqoop.model.MJob;
31
import org.apache.sqoop.validation.Validator;
31
import org.apache.sqoop.validation.Validator;
32

    
   
32

   
33
public class GenericJdbcConnector implements SqoopConnector {
33
public class GenericJdbcConnector extends SqoopConnector {
34

    
   
34

   
35
  private static final Importer IMPORTER = new Importer(
35
  private static final Importer IMPORTER = new Importer(
36
      GenericJdbcImportInitializer.class,
36
      GenericJdbcImportInitializer.class,
37
      GenericJdbcImportPartitioner.class,
37
      GenericJdbcImportPartitioner.class,
38
      GenericJdbcImportExtractor.class,
38
      GenericJdbcImportExtractor.class,
[+20] [20] 59 lines
spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java
Revision dc08675 New Change
 
  1. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java: Loading...
  2. spi/src/main/java/org/apache/sqoop/connector/spi/SqoopConnector.java: Loading...