Review Board 1.7.22


FLUME-1632: Persist progress on each file in file spooling client/source

Review Request #8596 - Created Dec. 14, 2012 and submitted

Mike Percy
FLUME-1632
Reviewers
Flume
flume-git
Defines EventDeserializer interface and uses it from the spooling source. Progress is persisted as bytes are read from the underlying file.
Unit tests pass.
Total:
20
Open:
10
Resolved:
9
Dropped:
1
Status:
From:
Description From Last Updated Status
Should this tool stuff be in core? Seems very useful for more than the forwarder... Brock Noland Dec. 14, 2012, 3:21 p.m. Open
Returns null if the name is not found Brock Noland Dec. 14, 2012, 3:21 p.m. Open
Probably a mistake? Brock Noland Dec. 14, 2012, 3:21 p.m. Open
How often do we feel storePosition is going to be called? The reason I am wondering is that sync is ... Brock Noland Dec. 14, 2012, 3:21 p.m. Open
Good catch. Mike Percy Dec. 16, 2012, 1:30 p.m. Open
Good idea. Mike Percy Dec. 16, 2012, 1:30 p.m. Open
sync() in this case is actually just writing a sync marker. But this sync() and flush() should be called once ... Mike Percy Dec. 16, 2012, 1:30 p.m. Open
Extra space in error message. Brock Noland Dec. 18, 2012, 5:44 p.m. Open
Why use direct memory here? Brock Noland Dec. 18, 2012, 5:44 p.m. Open
I figured it was something like that but I think that section could use a few comments describing what is ... Brock Noland Dec. 18, 2012, 9:28 p.m. Open
Review request changed
Updated (April 19, 2013, 6:05 a.m.)
  • changed from pending to submitted