Review Board 1.7.22


SQOOP-766 Sqoop2: Fix client resources

Review Request #8557 - Created Dec. 12, 2012 and submitted

Jarek Cecho
SQOOP-766
Reviewers
Sqoop
sqoop-sqoop2
I've fixed small nits and removed unnecessary empty lines.

 
client/src/main/java/org/apache/sqoop/client/core/Constants.java
Revision 72fe91c409433d2c52e5ef01083e284d1e3e8dc0 New Change
[20] 54 lines
[+20] [+] public class Constants {
55
  public static final char OPT_WEBAPP_CHAR = 'w';
55
  public static final char OPT_WEBAPP_CHAR = 'w';
56
  public static final char OPT_SERVER_CHAR = 's';
56
  public static final char OPT_SERVER_CHAR = 's';
57
  public static final char OPT_CLIENT_CHAR = 'c';
57
  public static final char OPT_CLIENT_CHAR = 'c';
58
  public static final char OPT_PROTOCOL_CHAR = 'p';
58
  public static final char OPT_PROTOCOL_CHAR = 'p';
59

    
   
59

   
60

    
   

   
61

    
   

   
62
  // Resource keys for various commands, command options,
60
  // Resource keys for various commands, command options,
63
  // functions and descriptions
61
  // functions and descriptions
64
  public static final String CMD_CLONE = "clone";
62
  public static final String CMD_CLONE = "clone";
65
  public static final String CMD_CLONE_SC = "\\cl";
63
  public static final String CMD_CLONE_SC = "\\cl";
66

    
   
64

   
[+20] [20] 74 lines
[+20] public class Constants {
141
  public static final String RES_PROMPT_FILL_CONN_METADATA =
139
  public static final String RES_PROMPT_FILL_CONN_METADATA =
142
      "prompt.fill_conn_metadata";
140
      "prompt.fill_conn_metadata";
143
  public static final String RES_PROMPT_FILL_JOB_METADATA =
141
  public static final String RES_PROMPT_FILL_JOB_METADATA =
144
      "prompt.fill_job_metadata";
142
      "prompt.fill_job_metadata";
145

    
   
143

   
146

    
   

   
147

    
   

   
148

    
   

   
149
  public static final String RES_CLONE_USAGE =
144
  public static final String RES_CLONE_USAGE =
150
      "clone.usage";
145
      "clone.usage";
151
  public static final String RES_CLONE_CONN_SUCCESSFUL =
146
  public static final String RES_CLONE_CONN_SUCCESSFUL =
152
      "clone.conn_successful";
147
      "clone.conn.successful";
153
  public static final String RES_CLONE_JOB_SUCCESSFUL =
148
  public static final String RES_CLONE_JOB_SUCCESSFUL =
154
      "clone.job.successful";
149
      "clone.job.successful";
155
  public static final String RES_CLONE_CLONING_CONN =
150
  public static final String RES_CLONE_CLONING_CONN =
156
      "clone.cloning_conn";
151
      "clone.cloning_conn";
157
  public static final String RES_CLONE_CLONING_JOB =
152
  public static final String RES_CLONE_CLONING_JOB =
158
      "clone.cloning_job";
153
      "clone.cloning_job";
159

    
   
154

   
160

    
   

   
161
  public static final String RES_CREATE_USAGE =
155
  public static final String RES_CREATE_USAGE =
162
      "create.usage";
156
      "create.usage";
163
  public static final String RES_CREATE_CONN_SUCCESSFUL =
157
  public static final String RES_CREATE_CONN_SUCCESSFUL =
164
      "create.conn_successful";
158
      "create.conn_successful";
165
  public static final String RES_CREATE_JOB_SUCCESSFUL =
159
  public static final String RES_CREATE_JOB_SUCCESSFUL =
166
      "create.job_successful";
160
      "create.job_successful";
167
  public static final String RES_CREATE_CREATING_CONN =
161
  public static final String RES_CREATE_CREATING_CONN =
168
      "create.creating_conn";
162
      "create.creating_conn";
169
  public static final String RES_CREATE_CREATING_JOB =
163
  public static final String RES_CREATE_CREATING_JOB =
170
      "create.creating_job";
164
      "create.creating_job";
171

    
   
165

   
172

    
   

   
173
  public static final String RES_DELETE_USAGE =
166
  public static final String RES_DELETE_USAGE =
174
      "delete.usage";
167
      "delete.usage";
175

    
   
168

   
176
  public static final String RES_HELP_USAGE =
169
  public static final String RES_HELP_USAGE =
177
      "help.usage";
170
      "help.usage";
[+20] [20] 47 lines
[+20] public class Constants {
225
  public static final String RES_SHOW_PROMPT_CONNS_TO_SHOW =
218
  public static final String RES_SHOW_PROMPT_CONNS_TO_SHOW =
226
      "show.prompt_conns_to_show";
219
      "show.prompt_conns_to_show";
227
  public static final String RES_SHOW_PROMPT_CONN_INFO =
220
  public static final String RES_SHOW_PROMPT_CONN_INFO =
228
      "show.prompt_conn_info";
221
      "show.prompt_conn_info";
229

    
   
222

   
230

    
   

   
231
  public static final String RES_SHOW_PROMPT_DISPLAY_ALL_CONNECTORS =
223
  public static final String RES_SHOW_PROMPT_DISPLAY_ALL_CONNECTORS =
232
      "show.prompt_display_all_connectors";
224
      "show.prompt_display_all_connectors";
233
  public static final String RES_SHOW_PROMPT_DISPLAY_CONNECTOR_CID =
225
  public static final String RES_SHOW_PROMPT_DISPLAY_CONNECTOR_CID =
234
      "show.prompt_display_connector_cid";
226
      "show.prompt_display_connector_cid";
235
  public static final String RES_SHOW_CONNECTOR_USAGE =
227
  public static final String RES_SHOW_CONNECTOR_USAGE =
[+20] [20] 49 lines
[+20] public class Constants {
285
  public static final String RES_SHOW_PROMPT_VERSION_CLIENT_SERVER =
277
  public static final String RES_SHOW_PROMPT_VERSION_CLIENT_SERVER =
286
      "show.prompt_version_client_server";
278
      "show.prompt_version_client_server";
287
  public static final String RES_SHOW_PROMPT_VERSION_PROTOCOL =
279
  public static final String RES_SHOW_PROMPT_VERSION_PROTOCOL =
288
      "show.prompt_version_protocol";
280
      "show.prompt_version_protocol";
289

    
   
281

   
290

    
   

   
291

    
   

   
292
  public static final String RES_SQOOP_SHELL_BANNER =
282
  public static final String RES_SQOOP_SHELL_BANNER =
293
      "sqoop.shell_banner";
283
      "sqoop.shell_banner";
294
  public static final String RES_SQOOP_PROMPT_SHELL_LOADRC =
284
  public static final String RES_SQOOP_PROMPT_SHELL_LOADRC =
295
      "sqoop.prompt_shell_loadrc";
285
      "sqoop.prompt_shell_loadrc";
296
  public static final String RES_SQOOP_PROMPT_SHELL_LOADEDRC =
286
  public static final String RES_SQOOP_PROMPT_SHELL_LOADEDRC =
297
      "sqoop.prompt_shell_loadedrc";
287
      "sqoop.prompt_shell_loadedrc";
298

    
   
288

   
299

    
   

   
300
  public static final String RES_SUBMISSION_USAGE =
289
  public static final String RES_SUBMISSION_USAGE =
301
      "submission.usage";
290
      "submission.usage";
302

    
   
291

   
303

    
   

   
304
  public static final String RES_UPDATE_USAGE =
292
  public static final String RES_UPDATE_USAGE =
305
      "update.usage";
293
      "update.usage";
306
  public static final String RES_UPDATE_UPDATING_CONN =
294
  public static final String RES_UPDATE_UPDATING_CONN =
307
      "update.updating_conn";
295
      "update.conn";
308
  public static final String RES_UPDATE_CONN_SUCCESSFUL =
296
  public static final String RES_UPDATE_CONN_SUCCESSFUL =
309
      "update.conn_successful";
297
      "update.conn_successful";
310
  public static final String RES_UPDATE_UPDATING_JOB =
298
  public static final String RES_UPDATE_UPDATING_JOB =
311
      "update.updating_job";
299
      "update.job";
312
  public static final String RES_UPDATE_JOB_SUCCESSFUL =
300
  public static final String RES_UPDATE_JOB_SUCCESSFUL =
313
      "update.job_successful";
301
      "update.job_successful";
314
  private Constants() {
302
  private Constants() {
315
    // Instantiation is prohibited
303
    // Instantiation is prohibited
316
  }
304
  }
317
}
305
}
client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
Revision 259739ae41b2b03cc971b2e0bb41b1a830f6ddc2 New Change
 
client/src/main/resources/client-resource.properties
Revision a65b37e196b2397655c0255f33a9ebd7d86680fd New Change
 
  1. client/src/main/java/org/apache/sqoop/client/core/Constants.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java: Loading...
  3. client/src/main/resources/client-resource.properties: Loading...