FLUME-1773. File Channel worker thread should not be daemon
Review Request #8433 - Created Dec. 8, 2012 and submitted
Using a single threaded scheduled executor, which is stopped when the channel is killed.
All unit tests pass
|Sorry I missed this before...why are we sysout'ing?||Brock Noland||Dec. 10, 2012, 9:34 p.m.||Open|
Posted (Dec. 10, 2012, 8:57 p.m.)
Looks like a good patch. There are unit tests where we set the checkpoint interval to 1 millisecond and is then overridden to 1 second by the current code. I think we should probably update the unit tests or add the Math.max() back in? Thoughts?
Posted (Dec. 10, 2012, 9:37 p.m.)
Review request changed
Updated (Dec. 17, 2012, 10:19 p.m.)
- changed from pending to submitted