FLUME-1768. Multiplexing channel selector should allow optional-only channels
Review Request #8387 - Created Dec. 6, 2012 and submitted
Added support for an optional channels only configuration.
Added 2 unit tests to test various sets of configs.
Posted (Dec. 7, 2012, 3:47 p.m.)
Looks good! One quick question to make sure I understand this correctly. If someone specifies no required channels the required channels list will just be empty and as such we'll only put the event on the optional channels. Similarly if there is no default channel and the event does not match a channel, the list returned will be empty? That makes sense to me, I just wanted to confirm.
Posted (Dec. 7, 2012, 6:25 p.m.)
Sorry, I found one more item. Looks like the user guide needs to be updated as well. For example I found this statement "The default must be set for a multiplexing select which can also contain any number of channels."
Review request changed
Updated (Dec. 8, 2012, 12:35 a.m.)
- changed from pending to submitted