FLUME-1626. HBase sink security support
Review Request #8365 - Created Dec. 5, 2012 and submitted
Did some basic testing against secure and non-secure hbase. I will update this patch as I test. This is an initial patch only, changes are likely.
|unused variable||Brock Noland||Dec. 6, 2012, 6:45 p.m.||Open|
|Should the runPrivileged be outside the loop?||Brock Noland||Dec. 6, 2012, 6:45 p.m.||Open|
|Nit: This code will be somehwhat hot, debug statement could be done one when debug logging is enabled.||Brock Noland||Dec. 6, 2012, 6:45 p.m.||Open|
Posted (Dec. 6, 2012, 6:45 p.m.)
Posted (Dec. 6, 2012, 7:34 p.m.)
Looks good! A couple more comments/questions below. Also, it looks like we could unit test a fair amount of HBaseSinkSecurityManager even if we cannot unit test the actual kerberos login portion at this time? Do you think that is possible?
Nit: Empty javadoc comment
Nit: Should we remove the return statement or fill it in?
This method will only be called when security is enabled correct? Assuming that is true do we want to return null from this method because the subsequent call to hbase will fail with an error message anyway, correct?
Nit: Looks like there is a space missing in the error message.
Review request changed
Updated (Jan. 24, 2013, 7:22 p.m.)
- changed from pending to submitted