Review Board 1.7.22


SQOOP-740 Provide export submission engine implementation for Sqoop 2

Review Request #8363 - Created Dec. 5, 2012 and submitted

Jarek Cecho
SQOOP-740
Reviewers
Sqoop
sqoop-sqoop2
I've provided basic implementation for export path in submission/execution engine. Current implementation have hard coded which extractor will be used. I would suggest to solve other extractors in follow up jira.
* Tests seems to be passing
* I've tested export on real cluster

Diff revision 2 (Latest)

1 2
1 2

  1. client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java: Loading...
  3. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java: Loading...
  4. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java: Loading...
  5. core/src/main/java/org/apache/sqoop/framework/ExecutionEngine.java: Loading...
  6. core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java: Loading...
  7. core/src/main/java/org/apache/sqoop/framework/configuration/ExportJobConfiguration.java: Loading...
  8. core/src/main/java/org/apache/sqoop/framework/configuration/ImportJobConfiguration.java: Loading...
  9. core/src/main/java/org/apache/sqoop/framework/configuration/InputForm.java: Loading...
  10. core/src/main/resources/framework-resources.properties: Loading...
  11. execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java: Loading...
  12. execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartitioner.java: Loading...
  13. execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceImportLoader.java: Loading...
  14. execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextImportLoader.java: Loading...
  15. execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java: Loading...
  16. execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java: Loading...
  17. execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java: Loading...
  18. spi/src/main/java/org/apache/sqoop/job/etl/Loader.java: Loading...
client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
Revision 734276dfdd88b121c64a608cb79db2f10900ae4b New Change
[20] 82 lines
[+20] [+] private void createConnection(String connectorId) throws IOException {
83

    
   
83

   
84
    MFramework framework = frameworkBean.getFramework();
84
    MFramework framework = frameworkBean.getFramework();
85
    ResourceBundle frameworkBundle = frameworkBean.getResourceBundle();
85
    ResourceBundle frameworkBundle = frameworkBean.getResourceBundle();
86

    
   
86

   
87
    MConnector connector = connectorBean.getConnectors().get(0);
87
    MConnector connector = connectorBean.getConnectors().get(0);
88
    ResourceBundle connectorBundle = connectorBean.getResourceBundles().get(0);
88
    ResourceBundle connectorBundle = connectorBean.getResourceBundles().get(connector.getPersistenceId());
89

    
   
89

   
90
    MConnection connection = new MConnection(connector.getPersistenceId(),
90
    MConnection connection = new MConnection(connector.getPersistenceId(),
91
                                             connector.getConnectionForms(),
91
                                             connector.getConnectionForms(),
92
                                             framework.getConnectionForms());
92
                                             framework.getConnectionForms());
93

    
   
93

   
[+20] [20] 26 lines
client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java
Revision 0b685bf1ab4e783a654cfc4b5737efb8fc23a566 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java
Revision 13574b2d8c9c534fc43b21fe3987d751c8064947 New Change
 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java
Revision c97693dc05a6e190a94e62ca6f76df6147319151 New Change
 
core/src/main/java/org/apache/sqoop/framework/ExecutionEngine.java
Revision ae14d9a8af0b2abb161c610cc8795e745fd3e110 New Change
 
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
Revision 66746437166aa05f6f3d9a454d0aeca77322cc49 New Change
 
core/src/main/java/org/apache/sqoop/framework/configuration/ExportJobConfiguration.java
Revision 330aff0dfcb6aa84d2d7f504e5a3a7528ff5217d New Change
 
core/src/main/java/org/apache/sqoop/framework/configuration/ImportJobConfiguration.java
Revision c674fc2615d9f35343ebc73387a79361ba68888a New Change
 
core/src/main/java/org/apache/sqoop/framework/configuration/InputForm.java
New File
 
core/src/main/resources/framework-resources.properties
Revision db40946242e204850066e2aa63325d895dd1e221 New Change
 
execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java
Revision e2163ff0c74cb0d11037a2ff114f6e748350a372 New Change
 
execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartitioner.java
Revision 9e7ea4e1231f3f26ad98adc5620169a037284cc7 New Change
 
execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceImportLoader.java
Revision a706ea84d9605dacfc57272328dcbafcc3501979 New Change
 
execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextImportLoader.java
Revision 55eb389084209d17fcb29072d5b7a393c6ea774b New Change
 
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java
Revision 3bd1e1b38aa57a9fd49f9960acd58492f49db9e3 New Change
 
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java
Revision 585fac7c82ed48f37704a951cf09b20ac547bdb0 New Change
 
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java
Revision c8caecd4abc4d8ec4b7d0c5055a1cecd05339de3 New Change
 
spi/src/main/java/org/apache/sqoop/job/etl/Loader.java
Revision 046b939b6ca535571f20cfb42273aef2ca05f868 New Change
 
  1. client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java: Loading...
  3. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportLoader.java: Loading...
  4. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java: Loading...
  5. core/src/main/java/org/apache/sqoop/framework/ExecutionEngine.java: Loading...
  6. core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java: Loading...
  7. core/src/main/java/org/apache/sqoop/framework/configuration/ExportJobConfiguration.java: Loading...
  8. core/src/main/java/org/apache/sqoop/framework/configuration/ImportJobConfiguration.java: Loading...
  9. core/src/main/java/org/apache/sqoop/framework/configuration/InputForm.java: Loading...
  10. core/src/main/resources/framework-resources.properties: Loading...
  11. execution/mapreduce/src/main/java/org/apache/sqoop/execution/mapreduce/MapreduceExecutionEngine.java: Loading...
  12. execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsExportPartitioner.java: Loading...
  13. execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsSequenceImportLoader.java: Loading...
  14. execution/mapreduce/src/main/java/org/apache/sqoop/job/etl/HdfsTextImportLoader.java: Loading...
  15. execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/SqoopOutputFormatLoadExecutor.java: Loading...
  16. execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsExtract.java: Loading...
  17. execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java: Loading...
  18. spi/src/main/java/org/apache/sqoop/job/etl/Loader.java: Loading...