Review Board 1.7.22


SQOOP-648 Moving localizable strings to resources and consolidate all String constants to Constants.java

Review Request #8305 - Created Dec. 1, 2012 and updated

Venkat Ranganathan
Reviewers
Sqoop
jarcec
sqoop-sqoop2
I have moved localizable strings to the client resources (those that are descriptions, messages in general etc).  Also consolidated constants to one place and removed repetitive occurrences.   

4 more files in utils need to be updated, but wanted to get this reviewed and take that after this
Ran the SQOOP2 client tests and manually ran various client commands to make sure that all commands have their localizable strings and constants properly displayed apart from running all the unit tests.   No new tests were added

Diff revision 3

This is not the most recent revision of the diff. The latest diff is revision 6. See what's changed.

1 2 3 4 5 6
1 2 3 4 5 6

  1. client/src/main/java/org/apache/sqoop/client/core/ClientError.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/core/Constants.java: Loading...
  3. client/src/main/java/org/apache/sqoop/client/request/Request.java: Loading...
  4. client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java: Loading...
  5. client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java: Loading...
  6. client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java: Loading...
  7. client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java: Loading...
  8. client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java: Loading...
  9. client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java: Loading...
  10. client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java: Loading...
  11. client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java: Loading...
  12. client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java: Loading...
  13. client/src/main/java/org/apache/sqoop/client/shell/HelpCommand.java: Loading...
  14. client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java: Loading...
  15. client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java: Loading...
  16. client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java: Loading...
  17. client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java: Loading...
  18. client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java: Loading...
  19. client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java: Loading...
  20. client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java: Loading...
This diff has been split across 2 pages: 1 2 >
client/src/main/java/org/apache/sqoop/client/core/ClientError.java
Revision fd3b97d New Change
[20] 19 lines
[+20]
20
import org.apache.sqoop.common.ErrorCode;
20
import org.apache.sqoop.common.ErrorCode;
21

    
   
21

   
22
public enum ClientError implements ErrorCode {
22
public enum ClientError implements ErrorCode {
23

    
   
23

   
24
  /** An unknown error has occurred. */
24
  /** An unknown error has occurred. */
25
  CLIENT_0000("An unknown error has occurred"),
25
  UNKNOWN_ERROR("An unknown error has occurred"),
26

    
   
26

   
27
  /** The specified command is not recognized. */
27
  /** The specified command is not recognized. */
28
  CLIENT_0001("The specified command is not recognized"),
28
  UNKNOWN_COMMAND("The specified command is not recognized"),
29

    
   
29

   
30
  /** The specified function is not recognized. */
30
  /** The specified function is not recognized. */
31
  CLIENT_0002("The specified function is not recognized"),
31
  UNKNOWN_FUNCTION("The specified function is not recognized"),
32

    
   
32

   
33
  /** An error has occurred when parsing options. */
33
  /** An error has occurred when parsing options. */
34
  CLIENT_0003("An error has occurred when parsing options"),
34
  UNKNOWN_OPTION("An error has occurred when parsing options"),
35

    
   
35

   
36
  /** Unable to resolve the variables. */
36
  /** Unable to resolve the variables. */
37
  CLIENT_0004("Unable to resolve the variables"),
37
  UNKNOWN_VARIABLE("Unable to resolve the variables"),
38

    
   
38

   
39
  /** We're not able to get user input */
39
  /** We're not able to get user input */
40
  CLIENT_0005("Can't get user input"),
40
  INPUT_ERROR("Can't get user input"),
41

    
   
41

   
42
  /** There occurred exception on server side **/
42
  /** There occurred exception on server side **/
43
  CLIENT_0006("Server has returned exception"),
43
  SERVER_EXCEPTION("Server has returned exception"),
44

    
   
44

   
45
  ;
45
  ;
46

    
   
46

   
47
  private final String message;
47
  private final String message;
48

    
   
48

   
[+20] [20] 12 lines
client/src/main/java/org/apache/sqoop/client/core/Constants.java
Revision 47c0547 New Change
 
client/src/main/java/org/apache/sqoop/client/request/Request.java
Revision 1720507 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java
Revision 847a6ad New Change
 
client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java
Revision 21c41aa New Change
 
client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java
Revision b0e8d90 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java
Revision 2453543 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
Revision 734276d New Change
 
client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java
Revision 0b685bf New Change
 
client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java
Revision bb09bf3 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java
Revision ee2a1cf New Change
 
client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java
Revision acc8e21 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/HelpCommand.java
Revision 03499d8 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java
Revision 20c8090 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
Revision 3764306 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java
Revision daf1ff4 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
Revision bd74253 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
Revision 4e49288 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
Revision a34c48c New Change
 
client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java
Revision 8dcf976 New Change
 
  1. client/src/main/java/org/apache/sqoop/client/core/ClientError.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/core/Constants.java: Loading...
  3. client/src/main/java/org/apache/sqoop/client/request/Request.java: Loading...
  4. client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java: Loading...
  5. client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java: Loading...
  6. client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java: Loading...
  7. client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java: Loading...
  8. client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java: Loading...
  9. client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java: Loading...
  10. client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java: Loading...
  11. client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java: Loading...
  12. client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java: Loading...
  13. client/src/main/java/org/apache/sqoop/client/shell/HelpCommand.java: Loading...
  14. client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java: Loading...
  15. client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java: Loading...
  16. client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java: Loading...
  17. client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java: Loading...
  18. client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java: Loading...
  19. client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java: Loading...
  20. client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java: Loading...
This diff has been split across 2 pages: 1 2 >