Review Board 1.7.22


FLUME-1723: AsyncHBase and Avro bring in different versions of Netty

Review Request #8109 - Created Nov. 18, 2012 and submitted

Mike Percy
FLUME-1723
Reviewers
Flume
flume-git
This patch makes Netty an explicit dependency for SDK (which uses Avro), Core (which uses Avro and also Netty directly), and HBase sink (which uses AsyncHBaseSink which depends on Netty).

It also excludes Netty as a dependency from avro-ipc and asynchbase.
Unit tests pass. Quick manual test. Also, mvn dependency:tree only lists a non-1.4.0 netty under hbase, which is marked as optional, so it is not brought in.
pom.xml
Revision 76b8351 New Change
[20] 680 lines
[+20]
681
        <exclusions>
681
        <exclusions>
682
          <exclusion>
682
          <exclusion>
683
            <groupId>org.mortbay.jetty</groupId>
683
            <groupId>org.mortbay.jetty</groupId>
684
            <artifactId>servlet-api</artifactId>
684
            <artifactId>servlet-api</artifactId>
685
          </exclusion>
685
          </exclusion>

    
   
686
          <exclusion>

    
   
687
            <groupId>io.netty</groupId>

    
   
688
            <artifactId>netty</artifactId>

    
   
689
          </exclusion>
686
        </exclusions>
690
        </exclusions>
687
      </dependency>
691
      </dependency>
688

    
   
692

   
689
      <dependency>
693
      <dependency>
690
        <groupId>org.apache.thrift</groupId>
694
        <groupId>org.apache.thrift</groupId>
[+20] [20] 250 lines
[+20]
941
      <exclusions>
945
        <exclusions>
942
        <exclusion>
946
          <exclusion>
943
          <groupId>org.slf4j</groupId>
947
            <groupId>org.slf4j</groupId>
944
          <artifactId>log4j-over-slf4j</artifactId>
948
            <artifactId>log4j-over-slf4j</artifactId>
945
        </exclusion>
949
          </exclusion>

    
   
950
          <exclusion>

    
   
951
            <groupId>org.jboss.netty</groupId>

    
   
952
            <artifactId>netty</artifactId>

    
   
953
          </exclusion>
946
      </exclusions>
954
        </exclusions>
947
     </dependency>
955
      </dependency>
948

    
   
956

   

    
   
957
      <dependency>

    
   
958
        <groupId>io.netty</groupId>

    
   
959
        <artifactId>netty</artifactId>

    
   
960
        <version>3.4.0.Final</version>

    
   
961
      </dependency>

    
   
962

   
949
    </dependencies>
963
    </dependencies>
950
  </dependencyManagement>
964
  </dependencyManagement>
951

    
   
965

   
952
  <reporting>
966
  <reporting>
953
    <plugins>
967
    <plugins>
[+20] [20] 36 lines
flume-ng-core/pom.xml
Revision d01baca New Change
 
flume-ng-sdk/pom.xml
Revision 1deab7e New Change
 
flume-ng-sinks/flume-ng-hbase-sink/pom.xml
Revision badb496 New Change
 
  1. pom.xml: Loading...
  2. flume-ng-core/pom.xml: Loading...
  3. flume-ng-sdk/pom.xml: Loading...
  4. flume-ng-sinks/flume-ng-hbase-sink/pom.xml: Loading...