Review Board 1.7.22


ZOOKEEPER-1346: Handle 4lws and monitoring on separate port (creating jetty server)

Review Request #8094 - Created Nov. 16, 2012 and updated

Skye Wanderman-Milne
trunk
ZOOKEEPER-1346
Reviewers
zookeeper
HenryR, phunt, skamille
zookeeper-git
See my comment in ZOOKEEPER-1346.
unit tests

Ran in standalone mode (only option right now) and manually tried out all the commands/links
Total:
11
Open:
3
Resolved:
7
Dropped:
1
Status:
From:
Description From Last Updated Status
Ditto on dumpWatches with the PrintWriter. Let's have one place for the logic for building up what should be written, ... Camille Fournier Nov. 18, 2012, 4:10 p.m. Open
Would you mind to make this lines 57 and 58 "final" too? Just a suggestion, but otherwise I think that ... Edward Ribeiro Jan. 17, 2013, 4:17 p.m. Open
Add Apache license (Jenkins alert). Edward Ribeiro Jan. 17, 2013, 11:52 p.m. Open
Review request changed
Updated (Jan. 17, 2013, 2:01 a.m.)
Added JettyAdminServerTest. This required some changes to make it work such as shutting down the Jetty server to make sure it released it port between tests and changing where the admin system properties are read so they are refreshed when a new server is created.

Rebased on trunk and addressed review comments.
Posted (Jan. 17, 2013, 4:17 p.m.)

   

  
Would you mind to make this lines 57 and 58  "final" too?

Just a suggestion, but otherwise I think that this patch is ready to ship. Congratulations on the good work. :)
Posted (Jan. 17, 2013, 11:53 p.m.)

   

  
Add Apache license (Jenkins alert).
  1. Skye has just added the license. It's okay to close this review now.