FLUME-1699. Make the rename of the meta file platform neutral
Review Request #8087 - Created Nov. 16, 2012 and submitted
If atomic rename fails, rename the current meta file to old, rename tmp to meta and then delete old.
All unit tests pass
|I think this will be better, because if these renames fail an error will be thrown below because the VERSION ...||Brock Noland||Nov. 19, 2012, 7:47 p.m.||Open|
Posted (Nov. 19, 2012, 7:47 p.m.)
I think this will be better, because if these renames fail an error will be thrown below because the VERSION header will be incorrect. However, it seems at this point we know that the .meta file should exist since there is a .meta.tmp or .meta.old so these renames failing should be a cause to halt and inform the user? At present the error message will be kind of confusion since if this logic is correct that error will only be seen if the file is corrupt.
Review request changed
Updated (Nov. 19, 2012, 11:37 p.m.)
- changed from pending to submitted