Review Board 1.7.22


ant checkstyle results in errors

Review Request #8010 - Created Nov. 11, 2012 and submitted

Alexander Alten-Lorenz
SQOOP-657
Reviewers
Sqoop
sqoop-trunk
cosmetic patch to solve ant checkstyle errors
ant checkstyle reports no errors, ant test was done

Diff revision 1 (Latest)

  1. src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java: Loading...
src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java
Revision 7ac1a79 New Change
[20] 192 lines
[+20] [+] private String getSelectListColumnsStr(String [] cols, String tableName) {
193
        LOG.error("can not find " + col + " in type medatadata");
193
        LOG.error("can not find " + col + " in type medatadata");
194
        sb.append(col);
194
        sb.append(col);
195
      } else {
195
      } else {
196
        if ("bool".equalsIgnoreCase(columnTypes.get(col))) {
196
        if ("bool".equalsIgnoreCase(columnTypes.get(col))) {
197
          sb.append(String.format("case when %s=true then 'TRUE' "
197
          sb.append(String.format("case when %s=true then 'TRUE' "
198
          + "when %s=false then 'FALSE' end as %s", colEscaped, colEscaped, colEscaped));
198
          + "when %s=false then 'FALSE' end as %s",

    
   
199
          colEscaped, colEscaped, colEscaped));
199
        } else if ("bit".equalsIgnoreCase(columnTypes.get(col))) {
200
        } else if ("bit".equalsIgnoreCase(columnTypes.get(col))) {
200
          sb.append(String.format("case when %s=B'1' then 'TRUE' "
201
          sb.append(String.format("case when %s=B'1' then 'TRUE' "
201
          + "when %s=B'0' then 'FALSE' end as %s", colEscaped, colEscaped, colEscaped));
202
          + "when %s=B'0' then 'FALSE' end as %s",

    
   
203
          colEscaped, colEscaped, colEscaped));
202
        } else {
204
        } else {
203
          sb.append(colEscaped);
205
          sb.append(colEscaped);
204
        }
206
        }
205
      }
207
      }
206
      first = false;
208
      first = false;
[+20] [20] 285 lines
  1. src/java/org/apache/sqoop/manager/DirectPostgresqlManager.java: Loading...