Review Board 1.7.22


SQOOP-686 Empty job name will result in NPE during job submission

Review Request #7945 - Created Nov. 8, 2012 and submitted

Jarek Cecho
SQOOP-686
Reviewers
Sqoop
sqoop-sqoop2
I've changed the code to use either job name (if available) or metadata persistent job id (always available).
I've tested this change on real cluster.
core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java
Revision f4be6395e9c8cff6d061dba40ad44fd48114406b New Change
[20] 309 lines
[+20] [+] public static MSubmission submit(long jobId) {
310
    SubmissionRequest request = executionEngine.createSubmissionRequest(
310
    SubmissionRequest request = executionEngine.createSubmissionRequest(
311
      summary, connector,
311
      summary, connector,
312
      connectorConnection, connectorJob,
312
      connectorConnection, connectorJob,
313
      frameworkConnection, frameworkJob);
313
      frameworkConnection, frameworkJob);
314
    request.setJobName(job.getName());
314
    request.setJobName(job.getName());

    
   
315
    request.setJobId(job.getPersistenceId());
315

    
   
316

   
316
    // Let's register all important jars
317
    // Let's register all important jars
317
    // sqoop-common
318
    // sqoop-common
318
    request.addJarForClass(MapContext.class);
319
    request.addJarForClass(MapContext.class);
319
    // sqoop-core
320
    // sqoop-core
[+20] [20] 223 lines
core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java
Revision c70a5cc5e7108e775d9f3cac7bb8fa5a56cbd0a3 New Change
 
submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java
Revision b8415e3f4f3c33361b5a02b752bf9b38eb341a91 New Change
 
  1. core/src/main/java/org/apache/sqoop/framework/FrameworkManager.java: Loading...
  2. core/src/main/java/org/apache/sqoop/framework/SubmissionRequest.java: Loading...
  3. submission/mapreduce/src/main/java/org/apache/sqoop/submission/mapreduce/MapreduceSubmissionEngine.java: Loading...