Review Board 1.7.22


SQOOP-680 Re enable unit tests for map reduce execution engine

Review Request #7906 - Created Nov. 6, 2012 and submitted

Jarek Cecho
SQOOP-680
Reviewers
Sqoop
sqoop-sqoop2
I've enabled or temporarily disabled tests.
Enabled tests seems to be working (passing).
common/src/main/java/org/apache/sqoop/common/MapContext.java
Revision b24514837caad11b105f4baee9bd514ecbdea1ff New Change
[20] 74 lines
[+20] [+] public long getLong(String key, long defaultValue) {
75
      return defaultValue;
75
      return defaultValue;
76
    }
76
    }
77

    
   
77

   
78
    String value = options.get(key);
78
    String value = options.get(key);
79

    
   
79

   
80
    return Long.getLong(value);
80
    return Long.parseLong(value);
81
  }
81
  }
82

    
   
82

   
83
  /**
83
  /**
84
   * {@inheritDoc}
84
   * {@inheritDoc}
85
   */
85
   */
86
  @Override
86
  @Override
87
  public int getInt(String key, int defaultValue) {
87
  public int getInt(String key, int defaultValue) {
88
    if(!options.containsKey(key)) {
88
    if(!options.containsKey(key)) {
89
      return defaultValue;
89
      return defaultValue;
90
    }
90
    }
91

    
   
91

   
92
    String value = options.get(key);
92
    String value = options.get(key);
93

    
   
93

   
94
    return Integer.getInteger(value);
94
    return Integer.parseInt(value);
95
  }
95
  }
96

    
   
96

   
97
  /**
97
  /**
98
   * Return all properties starting with given prefix (without the prefix itself)
98
   * Return all properties starting with given prefix (without the prefix itself)
99
   *
99
   *
[+20] [20] 14 lines
common/src/main/java/org/apache/sqoop/utils/ClassUtils.java
Revision 3f99f59e312ba6fd5d8c281dcdfa8f4d9d0018b2 New Change
 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java
Revision 532e6fdc3a53382a3411a713f9dc4f44ad3ca709 New Change
 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java
Revision 649808d44959b031a8aeab0d4997e9d5537f09c0 New Change
 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java
Revision d5c8b3c26b81beb7deccc67f1082c2c8c3b962b7 New Change
 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java
Revision 7d8c2820c89576542b66e55806a547b254cce04e New Change
 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
Revision c8b56c1a3d51c1f498e83d4d3c8434efdc98c02d New Change
 
execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java
Revision 59baaf688cf9af5ff4562335f75e97fd114c5b85 New Change
 
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java
Revision c74faa2bbaf9ea808e69b02a0b42f16469e17322 New Change
 
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestJobEngine.java
Revision 51dddb42e3840ffa7b64f186d83b71ea848b9a10 New Change
 
execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java
Revision 94ab560490cff8ccbfc24950c76ea3cb485ba37a New Change
 
execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java
Revision d4a7d4d63668935cdf8b8d43dfdd62a6502a250f New Change
 
  1. common/src/main/java/org/apache/sqoop/common/MapContext.java: Loading...
  2. common/src/main/java/org/apache/sqoop/utils/ClassUtils.java: Loading...
  3. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportInitializer.java: Loading...
  4. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestExportLoader.java: Loading...
  5. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java: Loading...
  6. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java: Loading...
  7. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java: Loading...
  8. execution/mapreduce/src/main/java/org/apache/sqoop/job/mr/ConfigurationUtils.java: Loading...
  9. execution/mapreduce/src/test/java/org/apache/sqoop/job/TestHdfsLoad.java: Loading...
  10. execution/mapreduce/src/test/java/org/apache/sqoop/job/TestJobEngine.java: Loading...
  11. execution/mapreduce/src/test/java/org/apache/sqoop/job/TestMapReduce.java: Loading...
  12. execution/mapreduce/src/test/java/org/apache/sqoop/job/io/TestData.java: Loading...