Review Board 1.7.22


Unable to display the MR Job log file path on Windows in case of MR job failures.

Review Request #7839 - Created Nov. 2, 2012 and updated

Kanna Karanam
hive
HIVE-3663
Reviewers
hive
ashutoshc, carl
hive
Because of this bunch of CLI negative tests are failing on windows.

 
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
Revision 1405070 New Change
[20] 32 lines
[+20]
33
import java.util.Map;
33
import java.util.Map;
34
import java.util.Set;
34
import java.util.Set;
35

    
   
35

   
36
import org.apache.commons.logging.Log;
36
import org.apache.commons.logging.Log;
37
import org.apache.commons.logging.LogFactory;
37
import org.apache.commons.logging.LogFactory;

    
   
38
import org.apache.hadoop.fs.Path;
38
import org.apache.hadoop.hive.common.JavaUtils;
39
import org.apache.hadoop.hive.common.JavaUtils;
39
import org.apache.hadoop.hive.conf.HiveConf;
40
import org.apache.hadoop.hive.conf.HiveConf;
40
import org.apache.hadoop.hive.ql.MapRedStats;
41
import org.apache.hadoop.hive.ql.MapRedStats;
41
import org.apache.hadoop.hive.ql.exec.Operator.ProgressCounter;
42
import org.apache.hadoop.hive.ql.exec.Operator.ProgressCounter;
42
import org.apache.hadoop.hive.ql.exec.errors.ErrorAndSolution;
43
import org.apache.hadoop.hive.ql.exec.errors.ErrorAndSolution;
[+20] [20] 595 lines
[+20] [+] public void localJobDebugger(int exitVal, String taskId) {
638
    console.printError(sb.toString());
639
    console.printError(sb.toString());
639

    
   
640

   
640
    for (Appender a : Collections.list((Enumeration<Appender>)
641
    for (Appender a : Collections.list((Enumeration<Appender>)
641
          LogManager.getRootLogger().getAllAppenders())) {
642
          LogManager.getRootLogger().getAllAppenders())) {
642
      if (a instanceof FileAppender) {
643
      if (a instanceof FileAppender) {
643
        console.printError(((FileAppender)a).getFile());
644
        console.printError((new Path(((FileAppender)a).getFile())).toUri().getPath());
644
      }
645
      }
645
    }
646
    }
646
  }
647
  }
647

    
   
648

   
648
  public int progressLocal(Process runningJob, String taskId) {
649
  public int progressLocal(Process runningJob, String taskId) {
[+20] [20] 153 lines
  1. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java: Loading...