Review Board 1.7.22


FLUME-1277: Error parsing Syslog rfc 3164 messages with null values

Review Request #7780 - Created Oct. 30, 2012 and submitted

Brock Noland
trunk
FLUME-1277
Reviewers
Flume
flume-git
The SyslogUtils class doesn't properly parse rfc 3164 style messages containing a null (hyphen) value. e.g., 
<10>Apr 1 13:14:04 ubuntu-11.cloudera.com - rest_of_message

It tries to parse it as a 5424 style message, skips over the date information, and interprets the first hyphen as a null timestamp. Part of the problem is the use of a Scanner and regex. This skips over a properly formatted 3164 style message until it finds anything that matches the 5424 regex, including a hyphen.
Unit test added and units pass
Total:
2
Open:
1
Resolved:
0
Dropped:
1
Status:
From:
Review request changed
Updated (Nov. 19, 2012, 7:20 p.m.)
  • changed from pending to submitted