Review Board 1.7.22


Modernize a chunk of the tests

Review Request #7734 - Created Oct. 25, 2012 and updated

Jonathan Coveney
PIG-3006
Reviewers
pig
julien
pig-git
A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:

- get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled?)
- Nothing should extend TestCase. Everything should be annotation driven.
- Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
- Get rid of MiniCluster use in a handful of cases.
I ran every test affected and they pass, except for TestLargeFile which is failing independently (I made no changes to TestLargeFile that should affect whether it passed, it was small and cosmetic)
test/org/apache/pig/test/PigExecTestCase.java
Revision 32a502c New Change
This file was deleted. The content cannot be displayed.
test/org/apache/pig/test/TestAlgebraicEval.java
Revision 0bbd83d New Change
 
test/org/apache/pig/test/TestAlgebraicEvalLocal.java
Revision df4b76a New Change
 
test/org/apache/pig/test/TestBagFormat.java
Revision 09298d4 New Change
 
test/org/apache/pig/test/TestBatchAliases.java
Revision 6e952c7 New Change
 
test/org/apache/pig/test/TestCompressedFiles.java
Revision d54ffaa New Change
 
test/org/apache/pig/test/TestConversions.java
Revision 152ad5c New Change
 
test/org/apache/pig/test/TestDeleteOnFail.java
Revision 7070285 New Change
 
test/org/apache/pig/test/TestFilterOpNumeric.java
Revision 730e808 New Change
 
test/org/apache/pig/test/TestFilterOpString.java
Revision b65965f New Change
 
test/org/apache/pig/test/TestFilterSimplification.java
Revision ade97b6 New Change
 
test/org/apache/pig/test/TestForEachNestedPlanLocal.java
Revision a78568e New Change
 
test/org/apache/pig/test/TestFuncSpec.java
Revision bc7144c New Change
 
test/org/apache/pig/test/TestInfixArithmetic.java
Revision cdf6948 New Change
 
test/org/apache/pig/test/TestInputOutputFileValidator.java
Revision 67b2873 New Change
 
test/org/apache/pig/test/TestInputOutputMiniClusterFileValidator.java
Revision caa62cb New Change
 
test/org/apache/pig/test/TestInstantiateFunc.java
Revision 31c37b1 New Change
 
test/org/apache/pig/test/TestJoin.java
Revision a4f3aff New Change
 
test/org/apache/pig/test/TestKeyTypeDiscoveryVisitor.java
Revision 2bbeca1 New Change
 
test/org/apache/pig/test/TestLargeFile.java
Revision 79590ce New Change
 
  1. test/org/apache/pig/test/PigExecTestCase.java: Loading...
  2. test/org/apache/pig/test/TestAlgebraicEval.java: Loading...
  3. test/org/apache/pig/test/TestAlgebraicEvalLocal.java: Loading...
  4. test/org/apache/pig/test/TestBagFormat.java: Loading...
  5. test/org/apache/pig/test/TestBatchAliases.java: Loading...
  6. test/org/apache/pig/test/TestCompressedFiles.java: Loading...
  7. test/org/apache/pig/test/TestConversions.java: Loading...
  8. test/org/apache/pig/test/TestDeleteOnFail.java: Loading...
  9. test/org/apache/pig/test/TestFilterOpNumeric.java: Loading...
  10. test/org/apache/pig/test/TestFilterOpString.java: Loading...
  11. test/org/apache/pig/test/TestFilterSimplification.java: Loading...
  12. test/org/apache/pig/test/TestForEachNestedPlanLocal.java: Loading...
  13. test/org/apache/pig/test/TestFuncSpec.java: Loading...
  14. test/org/apache/pig/test/TestInfixArithmetic.java: Loading...
  15. test/org/apache/pig/test/TestInputOutputFileValidator.java: Loading...
  16. test/org/apache/pig/test/TestInputOutputMiniClusterFileValidator.java: Loading...
  17. test/org/apache/pig/test/TestInstantiateFunc.java: Loading...
  18. test/org/apache/pig/test/TestJoin.java: Loading...
  19. test/org/apache/pig/test/TestKeyTypeDiscoveryVisitor.java: Loading...
  20. test/org/apache/pig/test/TestLargeFile.java: Loading...
This diff has been split across 3 pages: 1 2 3 >