Review Board 1.7.22


Modernize a chunk of the tests

Review Request #7734 - Created Oct. 25, 2012 and updated

Jonathan Coveney
PIG-3006
Reviewers
pig
julien
pig-git
A lot of the tests use antiquated patterns. My goal was to refactor them in a couple ways:

- get rid of the annotation specifying Junit 4. All should use JUnit 4 (question: where is the Junit 3 dependency even being pulled?)
- Nothing should extend TestCase. Everything should be annotation driven.
- Properly use asserts. There was a lot of assertTrue(null==thing), so I replaced it with assertNull(thing), and so on.
- Get rid of MiniCluster use in a handful of cases.
I ran every test affected and they pass, except for TestLargeFile which is failing independently (I made no changes to TestLargeFile that should affect whether it passed, it was small and cosmetic)
Total:
21
Open:
1
Resolved:
20
Dropped:
0
Status:
From:
Description From Last Updated Status
What is the accepted way of creating temporary datasets? Are we suggesting everybody to use mock.Storage() ? Gianmarco De Francisci Morales Oct. 25, 2012, 7:44 p.m. Open
Review request changed
Updated (Oct. 30, 2012, 1:10 a.m.)
I have taken into account comments, and this time I didn't use -w. It has whitespace changes. We'll see how that goes...