Review Board 1.7.22


FilterLogicExpressionSimplifier removed some branches in some cases

Review Request #743 - Created May 13, 2011 and submitted

Daniel Dai
PIG-2067
Reviewers
pig
rding
pig
See PIG-2067
Test-patch:
     [exec] -1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     -1 release audit.  The applied patch generated 562 release audit warnings (more than the trunk's current 561 warnings).
Ignore release audit warning since no new file is added.

Unit test:
    all pass

End-to-end test:
    all pass
Review request changed
Updated (May 13, 2011, 6:13 p.m.)
  • Unit test:
        all pass
    
    End-to-end test:
        all pass

    Test-patch:
         [exec] -1 overall.  
         [exec] 
         [exec]     +1 @author.  The patch does not contain any @author tags.
         [exec] 
         [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
         [exec] 
         [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
         [exec] 
         [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
         [exec] 
         [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
         [exec] 
         [exec]     -1 release audit.  The applied patch generated 562 release audit warnings (more than the trunk's current 561 warnings).
    Ignore release audit warning since no new file is added.
    
    Unit test:
        all pass
    
    End-to-end test:
        all pass