Review Board 1.7.22


SQOOP-619: Display user persistent id of newly created connection and job objects

Review Request #7410 - Created Oct. 3, 2012 and submitted

Jarek Cecho
SQOOP-619
Reviewers
Sqoop
sqoop-sqoop2
I've improved VerificationBean to also transfer ID if it's present and fixed user code to display it.
I've performed just manual testing.
client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java
Revision 9716de6 New Change
[20] 116 lines
[+20] [+] private void cloneConnection(String connectionId) throws IOException {
117

    
   
117

   
118
      // Try to create
118
      // Try to create
119
      status = createConnection(connection);
119
      status = createConnection(connection);
120
    } while(!status.canProceed());
120
    } while(!status.canProceed());
121

    
   
121

   
122
    io.out.println("Connection was successfully updated with status "
122
    io.out.println("Connection was successfully created with validation status "
123
      + status.name());
123
      + status.name() + " and persistent id " + connection.getPersistenceId());
124
  }
124
  }
125

    
   
125

   
126
  private Status createConnection(MConnection connection) {
126
  private Status createConnection(MConnection connection) {
127
    if (connectionRequest == null) {
127
    if (connectionRequest == null) {
128
      connectionRequest = new ConnectionRequest();
128
      connectionRequest = new ConnectionRequest();
[+20] [20] 13 lines
client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java
Revision 6c579d0 New Change
 
client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
Revision 904624c New Change
 
client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java
Revision 1a8b901 New Change
 
common/src/main/java/org/apache/sqoop/json/ValidationBean.java
Revision b56f6ed New Change
 
  1. client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java: Loading...
  3. client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java: Loading...
  4. client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java: Loading...
  5. common/src/main/java/org/apache/sqoop/json/ValidationBean.java: Loading...