Review Board 1.7.22


SQOOP-618: Remove most important FindBugs warnings and errors in Sqoop 2

Review Request #7409 - Created Oct. 3, 2012 and submitted

Jarek Cecho
SQOOP-618
Reviewers
Sqoop
sqoop-sqoop2
This patch removes cca 200 FindBugs warning and errors.
* mvn test
* Manual CRUD test for connection and job objects

Diff revision 2 (Latest)

1 2
1 2

  1. client/src/main/java/org/apache/sqoop/client/core/Environment.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java: Loading...
  3. client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java: Loading...
  4. client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java: Loading...
  5. common/src/main/java/org/apache/sqoop/common/ErrorCode.java: Loading...
  6. common/src/main/java/org/apache/sqoop/common/SqoopProtocolConstants.java: Loading...
  7. common/src/main/java/org/apache/sqoop/common/VersionInfo.java: Loading...
  8. common/src/main/java/org/apache/sqoop/json/JsonBean.java: Loading...
  9. common/src/main/java/org/apache/sqoop/json/ValidationBean.java: Loading...
  10. common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java: Loading...
  11. common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java: Loading...
  12. common/src/main/java/org/apache/sqoop/model/MConnection.java: Loading...
  13. common/src/main/java/org/apache/sqoop/model/MJob.java: Loading...
  14. common/src/main/java/org/apache/sqoop/model/MMapInput.java: Loading...
  15. common/src/main/java/org/apache/sqoop/model/MValidatedElement.java: Loading...
  16. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java: Loading...
  17. core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java: Loading...
  18. core/src/main/java/org/apache/sqoop/core/ConfigurationListener.java: Loading...
  19. core/src/main/java/org/apache/sqoop/core/ConfigurationProvider.java: Loading...
  20. core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java: Loading...
This diff has been split across 2 pages: 1 2 >
client/src/main/java/org/apache/sqoop/client/core/Environment.java
Revision 2afd0f7 New Change
[20] 17 lines
[+20]
18
package org.apache.sqoop.client.core;
18
package org.apache.sqoop.client.core;
19

    
   
19

   
20
import java.util.Locale;
20
import java.util.Locale;
21
import java.util.ResourceBundle;
21
import java.util.ResourceBundle;
22

    
   
22

   
23
public class Environment
23
public final class Environment
24
{
24
{
25
  private Environment() {
25
  private Environment() {
26
    // Disable explicit object creation
26
    // Disable explicit object creation
27
  }
27
  }
28

    
   
28

   
29
  private static String serverHost;
29
  private static String serverHost;
30
  private static String serverPort;
30
  private static String serverPort;
31
  private static String serverWebapp;
31
  private static String serverWebapp;
32

    
   
32

   
33
  private static String HOST_DEFAULT = "localhost";
33
  private static final String HOST_DEFAULT = "localhost";
34
  private static String PORT_DEFAULT = "8080";
34
  private static final String PORT_DEFAULT = "8080";
35
  private static String WEBAPP_DEFAULT = "sqoop";
35
  private static final String WEBAPP_DEFAULT = "sqoop";
36

    
   
36

   
37
  private static ResourceBundle resourceBundle;
37
  private static ResourceBundle resourceBundle;
38

    
   
38

   
39
  static {
39
  static {
40
    serverHost = HOST_DEFAULT;
40
    serverHost = HOST_DEFAULT;
[+20] [20] 39 lines
client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
Revision ee38407 New Change
 
client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java
Revision 02588c7 New Change
 
client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java
Revision 4e58a34 New Change
 
common/src/main/java/org/apache/sqoop/common/ErrorCode.java
Revision f53d972 New Change
 
common/src/main/java/org/apache/sqoop/common/SqoopProtocolConstants.java
Revision b06e059 New Change
 
common/src/main/java/org/apache/sqoop/common/VersionInfo.java
Revision 02f8cf3 New Change
 
common/src/main/java/org/apache/sqoop/json/JsonBean.java
Revision aa84935 New Change
 
common/src/main/java/org/apache/sqoop/json/ValidationBean.java
Revision 6883a85 New Change
 
common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
Revision 752acbe New Change
 
common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java
Revision dc4aac3 New Change
 
common/src/main/java/org/apache/sqoop/model/MConnection.java
Revision 97771a3 New Change
 
common/src/main/java/org/apache/sqoop/model/MJob.java
Revision 186716a New Change
 
common/src/main/java/org/apache/sqoop/model/MMapInput.java
Revision 9818d71 New Change
 
common/src/main/java/org/apache/sqoop/model/MValidatedElement.java
Revision a0c5074 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
Revision b1367ed New Change
 
core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java
Revision 8dc3704 New Change
 
core/src/main/java/org/apache/sqoop/core/ConfigurationListener.java
Revision e106043 New Change
 
core/src/main/java/org/apache/sqoop/core/ConfigurationProvider.java
Revision 3dcb853 New Change
 
core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java
Revision 8837dc9 New Change
 
  1. client/src/main/java/org/apache/sqoop/client/core/Environment.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java: Loading...
  3. client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java: Loading...
  4. client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java: Loading...
  5. common/src/main/java/org/apache/sqoop/common/ErrorCode.java: Loading...
  6. common/src/main/java/org/apache/sqoop/common/SqoopProtocolConstants.java: Loading...
  7. common/src/main/java/org/apache/sqoop/common/VersionInfo.java: Loading...
  8. common/src/main/java/org/apache/sqoop/json/JsonBean.java: Loading...
  9. common/src/main/java/org/apache/sqoop/json/ValidationBean.java: Loading...
  10. common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java: Loading...
  11. common/src/main/java/org/apache/sqoop/json/util/ResourceBundleSerialization.java: Loading...
  12. common/src/main/java/org/apache/sqoop/model/MConnection.java: Loading...
  13. common/src/main/java/org/apache/sqoop/model/MJob.java: Loading...
  14. common/src/main/java/org/apache/sqoop/model/MMapInput.java: Loading...
  15. common/src/main/java/org/apache/sqoop/model/MValidatedElement.java: Loading...
  16. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java: Loading...
  17. core/src/main/java/org/apache/sqoop/connector/ConnectorManager.java: Loading...
  18. core/src/main/java/org/apache/sqoop/core/ConfigurationListener.java: Loading...
  19. core/src/main/java/org/apache/sqoop/core/ConfigurationProvider.java: Loading...
  20. core/src/main/java/org/apache/sqoop/core/PropertiesConfigurationProvider.java: Loading...
This diff has been split across 2 pages: 1 2 >