Review Board 1.7.22


SQOOP-605 Generic JDBC connector for import

Review Request #7379 - Created Oct. 1, 2012 and submitted

Bilung Lee
SQOOP-605
Reviewers
Sqoop
sqoop-sqoop2
Provide import initializer, partitioner, and extractor for Generic JDBC connector.
Also modify the pom.xml to have better version management.

 

Diff revision 2 (Latest)

1 2
1 2

  1. pom.xml: Loading...
  2. connector/connector-generic-jdbc/pom.xml: Loading...
  3. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java: Loading...
  4. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java: Loading...
  5. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java: Loading...
  6. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java: Loading...
  7. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java: Loading...
  8. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java: Loading...
  9. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java: Loading...
  10. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartition.java: Loading...
  11. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java: Loading...
  12. connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties: Loading...
  13. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcTestConstants.java: Loading...
  14. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java: Loading...
  15. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java: Loading...
  16. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java: Loading...
  17. core/pom.xml: Loading...
  18. core/src/main/java/org/apache/sqoop/core/CoreError.java: Loading...
  19. core/src/main/java/org/apache/sqoop/job/JobConstants.java: Loading...
  20. spi/src/main/java/org/apache/sqoop/job/Constants.java: Loading...
  21. spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java: Loading...
  22. spi/src/main/java/org/apache/sqoop/job/etl/Options.java: Loading...
pom.xml
Revision 7549ea8 New Change
[20] 88 lines
[+20]
89

    
   
89

   
90
  <properties>
90
  <properties>
91
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
91
    <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
92
    <maven.compile.source>1.6</maven.compile.source>
92
    <maven.compile.source>1.6</maven.compile.source>
93
    <maven.compile.target>1.6</maven.compile.target>
93
    <maven.compile.target>1.6</maven.compile.target>
94
    <log4j.version>1.2.16</log4j.version>

   
95
    <json-simple.version>1.1</json-simple.version>

   
96
    <commons-dbcp.version>1.4</commons-dbcp.version>
94
    <commons-dbcp.version>1.4</commons-dbcp.version>

    
   
95
    <commons-lang.version>2.5</commons-lang.version>
97
    <derby.version>10.8.2.2</derby.version>
96
    <derby.version>10.8.2.2</derby.version>

    
   
97
    <hadoop.version>2.0.0-SNAPSHOT</hadoop.version>

    
   
98
    <json-simple.version>1.1</json-simple.version>
98
    <junit.version>4.9</junit.version>
99
    <junit.version>4.9</junit.version>

    
   
100
    <log4j.version>1.2.16</log4j.version>

    
   
101
    <servlet.version>2.5</servlet.version>
99
  </properties>
102
  </properties>
100

    
   
103

   
101
  <dependencies>
104
  <dependencies>
102
    <dependency>
105
    <dependency>
103
      <groupId>log4j</groupId>
106
      <groupId>log4j</groupId>
104
      <artifactId>log4j</artifactId>
107
      <artifactId>log4j</artifactId>
105
    </dependency>
108
    </dependency>
106
  </dependencies>
109
  </dependencies>
107

    
   
110

   
108
  <dependencyManagement>
111
  <dependencyManagement>
109
    <dependencies>
112
    <dependencies>
110
      <dependency>
113
      <dependency>
111
        <groupId>log4j</groupId>
114
        <groupId>org.apache.sqoop</groupId>
112
        <artifactId>log4j</artifactId>
115
        <artifactId>sqoop-client</artifactId>
113
        <version>${log4j.version}</version>
116
        <version>${project.version}</version>
114
      </dependency>
117
      </dependency>
115
      <dependency>
118
      <dependency>
116
        <groupId>javax.servlet</groupId>
119
        <groupId>org.apache.sqoop</groupId>
117
        <artifactId>servlet-api</artifactId>
120
        <artifactId>sqoop-common</artifactId>
118
        <version>2.5</version>
121
        <version>${project.version}</version>

    
   
122
      </dependency>

    
   
123
      <dependency>

    
   
124
        <groupId>org.apache.sqoop</groupId>

    
   
125
        <artifactId>sqoop-core</artifactId>

    
   
126
        <version>${project.version}</version>

    
   
127
      </dependency>

    
   
128
      <dependency>

    
   
129
        <groupId>org.apache.sqoop</groupId>

    
   
130
        <artifactId>sqoop-core</artifactId>

    
   
131
        <type>test-jar</type>

    
   
132
        <version>${project.version}</version>

    
   
133
      </dependency>

    
   
134
      <dependency>

    
   
135
        <groupId>org.apache.sqoop</groupId>

    
   
136
        <artifactId>sqoop-server</artifactId>

    
   
137
        <type>war</type>

    
   
138
        <version>${project.version}</version>

    
   
139
      </dependency>

    
   
140
      <dependency>

    
   
141
        <groupId>org.apache.sqoop</groupId>

    
   
142
        <artifactId>sqoop-spi</artifactId>

    
   
143
        <version>${project.version}</version>

    
   
144
      </dependency>

    
   
145
      <dependency>

    
   
146
        <groupId>org.apache.sqoop.repository</groupId>

    
   
147
        <artifactId>sqoop-repository-derby</artifactId>

    
   
148
        <version>${project.version}</version>

    
   
149
      </dependency>

    
   
150
      <dependency>

    
   
151
        <groupId>org.apache.sqoop.connector</groupId>

    
   
152
        <artifactId>sqoop-connector-generic-jdbc</artifactId>

    
   
153
        <version>${project.version}</version>

    
   
154
      </dependency>

    
   
155
      <dependency>

    
   
156
        <groupId>org.apache.sqoop.connector</groupId>

    
   
157
        <artifactId>sqoop-connector-generic-jdbc</artifactId>

    
   
158
        <type>test-jar</type>

    
   
159
        <version>${project.version}</version>

    
   
160
      </dependency>

    
   
161
      <dependency>

    
   
162
        <groupId>org.apache.sqoop.connector</groupId>

    
   
163
        <artifactId>sqoop-connector-mysql-jdbc</artifactId>

    
   
164
        <version>${project.version}</version>
119
      </dependency>
165
      </dependency>
120
      <dependency>
166
      <dependency>
121
        <groupId>com.googlecode.json-simple</groupId>
167
        <groupId>com.googlecode.json-simple</groupId>
122
        <artifactId>json-simple</artifactId>
168
        <artifactId>json-simple</artifactId>
123
        <version>${json-simple.version}</version>
169
        <version>${json-simple.version}</version>
124
      </dependency>
170
      </dependency>
125
      <dependency>
171
      <dependency>
126
        <groupId>commons-dbcp</groupId>
172
        <groupId>commons-dbcp</groupId>
127
        <artifactId>commons-dbcp</artifactId>
173
        <artifactId>commons-dbcp</artifactId>
128
        <version>${commons-dbcp.version}</version>
174
        <version>${commons-dbcp.version}</version>
129
      </dependency>
175
      </dependency>
130
      <dependency>
176
      <dependency>
131
        <groupId>org.apache.derby</groupId>
177
        <groupId>commons-lang</groupId>
132
        <artifactId>derby</artifactId>
178
        <artifactId>commons-lang</artifactId>
133
        <version>${derby.version}</version>
179
        <version>${commons-lang.version}</version>

    
   
180
      </dependency>

    
   
181
      <dependency>

    
   
182
        <groupId>javax.servlet</groupId>

    
   
183
        <artifactId>servlet-api</artifactId>

    
   
184
        <version>${servlet.version}</version>
134
      </dependency>
185
      </dependency>
135
      <dependency>
186
      <dependency>
136
        <groupId>junit</groupId>
187
        <groupId>junit</groupId>
137
        <artifactId>junit</artifactId>
188
        <artifactId>junit</artifactId>
138
        <version>${junit.version}</version>
189
        <version>${junit.version}</version>
139
      </dependency>
190
      </dependency>

    
   
191
      <dependency>

    
   
192
        <groupId>log4j</groupId>

    
   
193
        <artifactId>log4j</artifactId>

    
   
194
        <version>${log4j.version}</version>

    
   
195
      </dependency>

    
   
196
      <dependency>

    
   
197
        <groupId>org.apache.derby</groupId>

    
   
198
        <artifactId>derby</artifactId>

    
   
199
        <version>${derby.version}</version>

    
   
200
      </dependency>

    
   
201
      <dependency>

    
   
202
        <groupId>org.apache.hadoop</groupId>

    
   
203
        <artifactId>hadoop-common</artifactId>

    
   
204
        <version>${hadoop.version}</version>

    
   
205
      </dependency>

    
   
206
      <dependency>

    
   
207
        <groupId>org.apache.hadoop</groupId>

    
   
208
        <artifactId>hadoop-mapreduce-client-jobclient</artifactId>

    
   
209
        <version>${hadoop.version}</version>

    
   
210
      </dependency>
140
    </dependencies>
211
   </dependencies>
141
  </dependencyManagement>
212
  </dependencyManagement>
142

    
   
213

   
143
  <modules>
214
  <modules>
144
    <module>common</module>
215
    <module>common</module>
[+20] [20] 187 lines
connector/connector-generic-jdbc/pom.xml
Revision 382c669 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java
Revision 4363e0a New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java
Revision 0e45241 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java
New File
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java
New File
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java
Revision 2b0b621 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java
Revision aa7359e New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
Revision da730e4 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartition.java
Revision 2623f15 New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
Revision 0540729 New Change
 
connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
Revision c589339 New Change
 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcTestConstants.java
New File
 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java
New File
 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java
New File
 
connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
New File
 
core/pom.xml
Revision fc5bc2e New Change
 
core/src/main/java/org/apache/sqoop/core/CoreError.java
Revision 2697eef New Change
 
core/src/main/java/org/apache/sqoop/job/JobConstants.java
Revision 54fc543 New Change
 
spi/src/main/java/org/apache/sqoop/job/Constants.java
New File
 
spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java
Revision 00f1a6c New Change
 
spi/src/main/java/org/apache/sqoop/job/etl/Options.java
New File
 
  1. pom.xml: Loading...
  2. connector/connector-generic-jdbc/pom.xml: Loading...
  3. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnector.java: Loading...
  4. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java: Loading...
  5. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java: Loading...
  6. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExecutor.java: Loading...
  7. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcExportInitializer.java: Loading...
  8. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportExtractor.java: Loading...
  9. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java: Loading...
  10. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartition.java: Loading...
  11. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java: Loading...
  12. connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties: Loading...
  13. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/GenericJdbcTestConstants.java: Loading...
  14. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportExtractor.java: Loading...
  15. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportInitializer.java: Loading...
  16. connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java: Loading...
  17. core/pom.xml: Loading...
  18. core/src/main/java/org/apache/sqoop/core/CoreError.java: Loading...
  19. core/src/main/java/org/apache/sqoop/job/JobConstants.java: Loading...
  20. spi/src/main/java/org/apache/sqoop/job/Constants.java: Loading...
  21. spi/src/main/java/org/apache/sqoop/job/etl/Initializer.java: Loading...
  22. spi/src/main/java/org/apache/sqoop/job/etl/Options.java: Loading...