Review Board 1.7.22


In-process Hive CLI driver does not work

Review Request #7143 - Created Sept. 18, 2012 and submitted

David Robson
trunk
SQOOP-607
Reviewers
Sqoop
sqoop-trunk
Throw the exception from the old namespace to support anyone checking the old exception. Also update HiveImport to check the new namespace.
Created a mock Hive CLI that calls System.exit(0). Can see it now works.
Was trying to create an automated test but the problem was once I created the mock class it was used for the other tests as well instead of the shell script.
The easiest way I can see to create a unit test would be to allow the Hive CLI class to be specified as a parameter - that way it could be overridden in a unit test to a mock class.
Was also thinking about loading the class at runtime but this seemed like a bit of work for a small bug fix.
Total:
1
Open:
0
Resolved:
1
Dropped:
0
Status:
From:
Review request changed
Updated (Jan. 24, 2013, 5:30 a.m.)
  • changed from pending to submitted