Review Board 1.7.22

TestLoadBalancingSinkProcessor.testRoundRobinBackoffFailureRecovery is flaky, fails every once in a while...

Review Request #7020 - Created Sept. 11, 2012 and submitted

Ted Malaska
It is possible that it is a clock issue.

because s2 has to wait 2000 mil/s because of the following line
state.restoreTime = now + Math.min(MAX_TIMEOUT, 1000 * (1 << state.sequentialFails));

But then the test waits 2000 mil/s before starting the loop again.  

There is a chance that we reach the following if statement at only 2000 mil/s passing

if (state.restoreTime < curTime) {

So I'm going to increase the wait to 2001 mil/s.  That should do it.

Review request changed
Updated (Oct. 13, 2012, 3:55 p.m.)
  • changed from pending to submitted