Review Board 1.7.22


Remove TotalOrderPartitioner

Review Request #6916 - Created Sept. 5, 2012 and updated

enis
hbase-6706
Reviewers
hbase
hbase-git
We can remove o.a.h.h.mapreduce.hadoopbackport.* classes since we are going to drop support for hadoop 0.20.

Attaching a patch which does:
Introduce HadoopShims interface in hadoop-compat, and implementations for hadoop1 and hadoop2
Remove o.a.h.h.mapreduce.hadoopbackport package.
The following tests passed for me:
MAVEN_OPTS=-Xmx512m mvn test -Dtest=TestHFileOutputFormat -PlocalTests
MAVEN_OPTS=-Xmx512m mvn test -Dhadoop.profile=2.0 -Dtest=TestHFileOutputFormat -PlocalTests
MAVEN_OPTS=-Xmx512m mvn test -Dhadoop.profile=2.0 -Dtest=TestHFileOutputFormat -PlocalTests -Dhadoop.version=0.23.2
Total:
6
Open:
6
Resolved:
0
Dropped:
0
Status:
From:
Ship it!
Posted (Sept. 5, 2012, 2:55 a.m.)
Looks great.  A few questions in the below.  Thanks Enis.
Why would we not want to add this to src/main?  It looks good.This is an adapter that will work against hadoop1 and hadoop2?  The implementation is provided by h1 or h2 compat layer?
  1. Yes, we can put all the stuff in Hadoop that needs a shim layer here. h1 and h2 compat modules provide the actual implementation of the HadoopShims interface. We can definitely put this under src/main, but smt like createTaskAttempt() wont be needed by the main code, which is why I put had put the classes under src/test. Let me update the patch if you think that src/main will be better. 
  2. I'm fine with it as is.  I does put an onus on us to make sure others know this little shim doohickey exists and that if they want such a device, that its there to be moved over.  Good stuff Enis.
  3. Ok cool, then we can go with this version. If something comes up, we should remember to use this though. 
hbase-hadoop1-compat/pom.xml (Diff revision 1)
 
 
So move pom.xml compat jar down here?  That makes sense.
Can we remove the whole hadoopbackport package yet?
pom.xml (Diff revision 1)
 
 
We don't need this here?  Thanks for clean up Enis.
Posted (Sept. 5, 2012, 6:11 p.m.)

   

  
hbase-hadoop1-compat/pom.xml (Diff revision 1)
 
 
This adds a dependency to the test-jar of hadoop-compat.
Yes, there are only 2 classes TOP and InputSampler, both of which are not needed anymore