AutoScale. Aligning the NetScaler response time counter, and correcting duration check against interval
Review Request #6895 - Created Sept. 3, 2012 and submitted
1. Better names for default counters (removed special characters etc) 2. Aligning the Netscaler response time counter to the right unit. (changing from milliseconds to microseconds) 3. Duration cannot be less than interval and making QuietTime independent of interval.
1. deploydb succeeds. 2. Testing duration check. a. create autoscale config (duration=300), (interval=30) b. fire updateAutoScalePolicy with duration=25. #checks update path. 3. Testing quiettime independency. a. create autoscale config (quiettime=25), (interval=30) #verifies create path b. fire updateAutoScalePolicy with quiettime=24. #verifies update path
Posted (Sept. 5, 2012, 4:45 a.m.)
The changes look fine. There are few places in AutoScaleManagerImpl.java where whitespaces have been removed in the if statement. Looks like it is not needed. Can you resubmit this patch after correcting it.
Review request changed
Updated (Sept. 13, 2012, 5:29 a.m.)
- changed from pending to submitted