FLUME-1534: ComparableFlumeEventPointer#equals method does not work.
Review Request #6892 - Created Sept. 2, 2012 and submitted
The equals() method in ComparableFlumeEventPointer was not working correctly, and hence remove() calls from sets were not removing anything.
Posted (Sept. 2, 2012, 8:43 p.m.)
Doesn't this violate the Liskov substitution principal (EJ 2nd ed, p39-40)? If it doesn't make sense to subclass the ComparableFlumeEventPointer class, then can we make the class final?
Considering the case where pointer can be null, we can use Guava's Objects.equal(..) method: return Objects.equal(this.pointer, ((ComparableFlumeEventPointer)o).pointer);
Review request changed
Updated (Sept. 3, 2012, 6:58 a.m.)
- changed from pending to submitted