Review Board 1.7.22


Dynamic reconfiguration, see https://issues.apache.org/jira/browse/ZOOKEEPER-107

Review Request #6707 - Created Aug. 21, 2012 and updated

Alexander Shraer
Reviewers
zookeeper
zookeeper
see https://issues.apache.org/jira/browse/ZOOKEEPER-107
New test files were added: ReconfigTest, ReconfigRecoveryTest and QuorumMajorityTest. Many other tests were modified. 

Diff revision 5

This is not the most recent revision of the diff. The latest diff is revision 7. See what's changed.

1 2 3 4 5 6 7
1 2 3 4 5 6 7

  1. /src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java: Loading...
  2. /src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java: Loading...
  3. /src/java/main/org/apache/zookeeper/server/quorum/Follower.java: Loading...
  4. /src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java: Loading...
  5. /src/java/main/org/apache/zookeeper/server/quorum/Leader.java: Loading...
  6. /src/java/main/org/apache/zookeeper/server/quorum/Learner.java: Loading...
  7. /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java: Loading...
  8. /src/java/main/org/apache/zookeeper/server/quorum/Observer.java: Loading...
  9. /src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java: Loading...
  10. /src/java/main/org/apache/zookeeper/server/quorum/QuorumBean.java: Loading...
  11. /src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java: Loading...
  12. /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java: Loading...
  13. /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java: Loading...
  14. /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java: Loading...
  15. /src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java: Loading...
  16. /src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java: Loading...
  17. /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java: Loading...
  18. /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java: Loading...
  19. /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumVerifier.java: Loading...
  20. /src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java: Loading...
  21. /src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java: Loading...
  22. /src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java: Loading...
  23. /src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java: Loading...
  24. /src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java: Loading...
  25. /src/java/test/org/apache/zookeeper/test/CnxManagerTest.java: Loading...
  26. /src/java/test/org/apache/zookeeper/test/NIOConnectionFactoryFdLeakTest.java: Loading...
  27. /src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java: Loading...
  28. /src/java/test/org/apache/zookeeper/test/QuorumUtil.java: Loading...
  29. /src/java/test/org/apache/zookeeper/test/ReconfigTest.java: Loading...
This diff has been split across 2 pages: < 1 2
/src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java
Revision 1438352 New Change
[20] 128 lines
[+20] [+] private boolean isProcessingCommit() {
129
    protected boolean needCommit(Request request) {
129
    protected boolean needCommit(Request request) {
130
        switch (request.type) {
130
        switch (request.type) {
131
            case OpCode.create:
131
            case OpCode.create:
132
            case OpCode.delete:
132
            case OpCode.delete:
133
            case OpCode.setData:
133
            case OpCode.setData:

    
   
134
            case OpCode.reconfig:
134
            case OpCode.multi:
135
            case OpCode.multi:
135
            case OpCode.setACL:
136
            case OpCode.setACL:
136
            case OpCode.createSession:
137
            case OpCode.createSession:
137
            case OpCode.closeSession:
138
            case OpCode.closeSession:
138
                return true;
139
                return true;
[+20] [20] 207 lines
/src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/Follower.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/Leader.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/Learner.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/Observer.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/QuorumBean.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumVerifier.java
Revision 1438352 New Change
 
/src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java
New File
 
/src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java
Revision 1438352 New Change
 
/src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java
Revision 1438352 New Change
 
/src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java
New File
 
/src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java
Revision 1438352 New Change
 
/src/java/test/org/apache/zookeeper/test/CnxManagerTest.java
Revision 1438352 New Change
 
/src/java/test/org/apache/zookeeper/test/NIOConnectionFactoryFdLeakTest.java
Revision 1438352 New Change
 
/src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java
New File
 
/src/java/test/org/apache/zookeeper/test/QuorumUtil.java
Revision 1438352 New Change
 
/src/java/test/org/apache/zookeeper/test/ReconfigTest.java
New File
 
  1. /src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java: Loading...
  2. /src/java/main/org/apache/zookeeper/server/quorum/FastLeaderElection.java: Loading...
  3. /src/java/main/org/apache/zookeeper/server/quorum/Follower.java: Loading...
  4. /src/java/main/org/apache/zookeeper/server/quorum/FollowerRequestProcessor.java: Loading...
  5. /src/java/main/org/apache/zookeeper/server/quorum/Leader.java: Loading...
  6. /src/java/main/org/apache/zookeeper/server/quorum/Learner.java: Loading...
  7. /src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java: Loading...
  8. /src/java/main/org/apache/zookeeper/server/quorum/Observer.java: Loading...
  9. /src/java/main/org/apache/zookeeper/server/quorum/ObserverRequestProcessor.java: Loading...
  10. /src/java/main/org/apache/zookeeper/server/quorum/QuorumBean.java: Loading...
  11. /src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java: Loading...
  12. /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java: Loading...
  13. /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java: Loading...
  14. /src/java/main/org/apache/zookeeper/server/quorum/QuorumPeerMain.java: Loading...
  15. /src/java/main/org/apache/zookeeper/server/quorum/QuorumZooKeeperServer.java: Loading...
  16. /src/java/main/org/apache/zookeeper/server/quorum/ReadOnlyRequestProcessor.java: Loading...
  17. /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumHierarchical.java: Loading...
  18. /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumMaj.java: Loading...
  19. /src/java/main/org/apache/zookeeper/server/quorum/flexible/QuorumVerifier.java: Loading...
  20. /src/java/main/org/apache/zookeeper/server/util/ConfigUtils.java: Loading...
  21. /src/java/main/org/apache/zookeeper/server/util/SerializeUtils.java: Loading...
  22. /src/java/test/org/apache/zookeeper/server/quorum/QuorumPeerTestBase.java: Loading...
  23. /src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java: Loading...
  24. /src/java/test/org/apache/zookeeper/server/quorum/Zab1_0Test.java: Loading...
  25. /src/java/test/org/apache/zookeeper/test/CnxManagerTest.java: Loading...
  26. /src/java/test/org/apache/zookeeper/test/NIOConnectionFactoryFdLeakTest.java: Loading...
  27. /src/java/test/org/apache/zookeeper/test/QuorumMajorityTest.java: Loading...
  28. /src/java/test/org/apache/zookeeper/test/QuorumUtil.java: Loading...
  29. /src/java/test/org/apache/zookeeper/test/ReconfigTest.java: Loading...
This diff has been split across 2 pages: < 1 2