Review Board 1.7.22


Hooks for tracing.

Review Request #6454 - Created Aug. 7, 2012 and updated

Jonathan Leavitt
Reviewers
hbase
hbase-git
Adds hooks to add dapper-like tracing to hbase through the use of the htrace tracing library (github.com/cloudera/htrace)

 
Total:
22
Open:
4
Resolved:
18
Dropped:
0
Status:
From:
Description From Last Updated Status
Is there a KeyValue elsewhere in a .proto? Could cause problems having same class name? Can you add comments to ... Michael Stack Aug. 8, 2012, 12:18 a.m. Open
what's the purpose of this layer of indirection over LocalFileSpanReceiver? It's to avoid a dependency of HTrace itself on Hadoop ... Todd Lipcon Aug. 8, 2012, 12:25 a.m. Open
set rcvr = null and initialized = false here? Todd Lipcon Aug. 8, 2012, 12:25 a.m. Open
getTrimmedStrings - then you dont need to trim below Todd Lipcon Aug. 8, 2012, 12:25 a.m. Open
Review request changed
Updated (Aug. 21, 2012, 1:33 a.m.)
changed testing
works now with protobuf rpc engine.
sorry for sending out this same patch on the other review board (the other one was for the tracing library, this is only for the hooks).