Review Board 1.7.22


Improvement for Log4j configuration

Review Request #6316 - Created Aug. 2, 2012 and updated

Denny Ye
trunk
FLUME-1418
Reviewers
Flume
hshreedharan
Flume
Updated log4j.properties 
1. Add 'logs' folder. It's better to aggregate logs into unified folder.
2. Log file using DailyRollingFileAppender
3. More useful log pattern. Add thread and code line information
4. Set debug level for Hadoop. If we use debug level, Hadoop log takes too many lines.
That's OK in my environment
Review request changed
Updated (Aug. 7, 2012, 2:19 a.m.)
1. Delay changes in DatedFileAppender
2. Change '%-5p' location before thread name
Ship it!
Posted (Aug. 7, 2012, 4:05 a.m.)
+1
  1. Looks good. Please attach the latest patch to the JIRA.
  2. Thanks, Patch has already submitted to JIRA
  3. Looks like you just updated it, but you specified "Grant ASF License" = "No". Please resubmit and grant a license to include this in ASF works.