Review Board 1.7.22


Fixing aggregators

Review Request #6134 - Created July 25, 2012 and submitted

Maja Kabiljo
GIRAPH-259
Reviewers
giraph
giraph
Now by default all aggregators are reset at the end of each super step. Aggregators can also be registered as persistent from master, and their value is aggregated value from all super steps.

In all compute() executions the value of aggregator from previous super step is visible, and changes are made on a separate instance, but transparent to the user. 

I made all the aggregators a bit simpler by creating BasicAggregator which keeps value and implements get and set, and aggregators for types (IntAggregator, DoubleAggregator...) which implement createAggregatedValue.

TestBspBasic.testBspMasterCompute was assuming that vertices see the change master.compute makes in current super step, that's why the value there is changed.
mvn verify
Review request changed
Updated (Aug. 24, 2012, 1:35 p.m.)
  • changed from pending to submitted