Review Board 1.7.22


HTableFactory.releaseHTableInterface() wraps IOException in RuntimeException

Review Request #574 - Created April 11, 2011 and updated

Ted Yu
trunk
HBASE-3762
Reviewers
hbase
ghelmling
hbase
Currently HTableFactory.releaseHTableInterface() wraps IOException in RuntimeException.
We should let HTableInterfaceFactory.releaseHTableInterface() throw IOException explicitly.
TestHTablePool and TestAvroServer pass.
Ship it!
Posted (April 11, 2011, 6:13 p.m.)
Patch looks good Ted.

Just a couple minor comments on the TestHTablePool additions.  But those could be fixed up on commit.
Very minor nit: extra space before catch
I think you should just use fail() here with a message we got an unexpected exception.
  1. On second thought, no need to even handle the IOException here.  Just let it escape and fail the test.
Same as above, fail() would be clearer.
Ship it!
Posted (April 11, 2011, 6:23 p.m.)
Looks good to me. Better to be explicit than throwing a spurious RuntimeException. This makes the API more coherent.
  1. I second Gary's comment though, forgot to mention that.