Review Board 1.7.22


When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface()

Review Request #573 - Created April 9, 2011 and updated

Ted Yu
trunk
HBASE-3750
Reviewers
hbase
larsgeorge
hbase
When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
TestHTablePool passes.
Review request changed
Updated (April 10, 2011, 4:18 a.m.)
  • Currently HTablePool.putTable() doesn't call table.flushCommits()
    If AutoFlush is disabled for table instance, we should call table.flushCommits().
    
    When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().

    When HTable instance is discarded in putTable(), we should call tableFactory.releaseHTableInterface().
I only kept the call to tableFactory.releaseHTableInterface()
Ship it!
Posted (April 10, 2011, 5:13 a.m.)
Looks good.  Thanks for the patch Ted!
Ship it!
Posted (April 10, 2011, 8:07 a.m.)
That's exactly what I meant. Thanks Ted.

Also thank you for removing the obsolete imports.