Encoded JS urls fail to split features properly
Review Request #5688 - Created June 30, 2012 and submitted
We need to decode the url before we try to parse it. My initial approach to this was to change the way in which we build the Uri object, decoding all of the pieces at build time. This approach caused several issues in the proxy uri area. In order to cause less churn and risk of regression in the code, I decided to simply decode the path in the DefaultJsUriManager
Added a new JUnit to address the issue of an encoded path in a Js Uri. All existing tests pass as well.
Posted (July 2, 2012, 5:41 p.m.)
+1 but I would suggest to add comment about why we url decode here rather that in the URI builder of URI class itself. Maybe with extra time after 2.5 release we could move the logic up for all URI managers.
Review request changed
Updated (July 2, 2012, 6:12 p.m.)
- changed from pending to submitted