Review Board 1.7.22


Possible js compiler cache miss scenario

Review Request #5677 - Created June 29, 2012 and submitted

Dan Dumont
SHINDIG-1834
Reviewers
shindig
hsaputra, johnfargo, lindner, rbaxter, ssievers
shindig
We've noticed over here that the request url for a page of feature code javascript is included in the actual output.
This means that altering the url slightly will result in a cache-miss as the content changes, even if you append bogus features.

Obviously this is not ideal.
I don't think that the config override mechanism that uses the request url is exactly necessary... or even used!
I've tried my best to adapt the config override mechanism and maintain the previous functionality.  It's mostly the same with a small caveat.

I would really appreciate a review from John H, as I think he was the original contributor of the override stuff.
Js tests updated and passing.
Java test updated and passing.
Total:
18
Open:
0
Resolved:
16
Dropped:
2
Status:
From:
Description From Last Updated Status
Review request changed
Updated (Aug. 1, 2012, 6:01 p.m.)
  • changed from pending to submitted