Review Board 1.7.22


HIVE-3179: HBase Handler doesn't handle NULLs properly

Review Request #5542 - Created June 25, 2012 and updated

Lars Francke
HIVE-3179
Reviewers
hive
hive-git
This patch moves the initialization of the fieldsInited variable to the end of the loop because otherwise NULL values will return stale data on the second iteration. All other cases should be unaffected by this change. 
Debugged problem, added code to existing test to force wrong behavior which is fixed by this patch, ran the hbase-handler unit tests
Total:
1
Open:
1
Resolved:
0
Dropped:
0
Status:
From:
Review request changed
Updated (June 25, 2012, 5:30 a.m.)
  • changed from HBase Handler doesn't handle NULLs properly to HIVE-3179: HBase Handler doesn't handle NULLs properly
Ship it!
Posted (Feb. 7, 2013, 10:11 p.m.)
Ship It!
  1. I am not a committer.
Ship it!
Posted (Feb. 7, 2013, 10:21 p.m.)
Ship It!
Posted (Feb. 8, 2013, 3:33 p.m.)

   

  
Lars, I noticed that the Javadoc here is inconsistent with the method signature. This is obviously unrelated to your change but if you have a chance, could you please correct the Javadoc here?
  1. Mark,
    
    I agree we should update the javadoc, however I don't think that should hold up a commit since it's unrelated to this change and this issue is critical. That is if Lars doesn't update the patch we can address that issue in a new JIRA. Would you agree?  
    
    Brock
  2. Fair enough, that's fine by me.