Review Board 1.7.22


New logical plan: Should not push up filter in front of Bincond

Review Request #544 - Created April 2, 2011 and submitted

Daniel Dai
branch-0.8
PIG-1935
Reviewers
pig
thejas
pig
The following script produce wrong result:

data = LOAD 'data.txt' using PigStorage() as (referrer:chararray, canonical_url:chararray, ip:chararray);
best_url = FOREACH data GENERATE ((canonical_url != '' and canonical_url is not null) ? canonical_url : referrer) AS url, ip;
filtered = FILTER best_url BY url == 'badsite.com';
dump filtered;

data.txt:
badsite.com 127.0.0.1
goodsite.com/1?foo=true goodsite.com 127.0.0.1

Expected:
(badsite.com,127.0.0.1)

We get nothing.
test-patch:
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.

Unit test:
    all pass

End-to-end test:
    all pass
Content-Type: text/html; charset=utf-8
http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java
Revision 1085215 New Change
Diff currently unavailable.
Error: The patch to 'http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.ziWuQG' for debugging purposes. `patch` returned: patching file /tmp/reviewboard.ziWuQG/tmpcsxOTy Hunk #1 FAILED at 98. 1 out of 1 hunk FAILED -- saving rejects to file /tmp/reviewboard.ziWuQG/tmpcsxOTy-new.rej
Details
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/views.py", line 117, in view_diff
    request=request)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 344, in populate_diff_chunks
    chunks = generator.get_chunks()
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 137, in get_chunks
    large_data=True)
  File "/usr/local/lib/python2.7/dist-packages/Djblets-0.7.28-py2.7.egg/djblets/util/misc.py", line 157, in cache_memoize
    data = lookup_callable()
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 136, in <lambda>
    lambda: list(self._get_chunks_uncached()),
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/chunk_generator.py", line 142, in _get_chunks_uncached
    new = get_patched_file(old, self.filediff, self.request)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 152, in get_patched_file
    return patch(diff, buffer, filediff.dest_file, request)
  File "/usr/local/lib/python2.7/dist-packages/ReviewBoard-1.7.22-py2.7.egg/reviewboard/diffviewer/diffutils.py", line 96, in patch
    (filename, tempdir, patch_output))
Exception: The patch to 'http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java' didn't apply cleanly. The temporary files have been left in '/tmp/reviewboard.ziWuQG' for debugging purposes.
`patch` returned: patching file /tmp/reviewboard.ziWuQG/tmpcsxOTy
Hunk #1 FAILED at 98.
1 out of 1 hunk FAILED -- saving rejects to file /tmp/reviewboard.ziWuQG/tmpcsxOTy-new.rej

http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanFilterAboveForeach.java
Revision 1085215 New Change
 
  1. http://svn.apache.org/repos/asf/pig/trunk/src/org/apache/pig/newplan/logical/expression/BinCondExpression.java: Loading...
  2. http://svn.apache.org/repos/asf/pig/trunk/test/org/apache/pig/test/TestNewPlanFilterAboveForeach.java: Loading...